refactor: shape perf #19023

Xiaoy312 · 2024-12-06T02:41:33Z

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Docs have been added/updated which fit documentation template (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Validated PR Screenshots Compare Test Run results.
Contains NO breaking changes
Associated with an issue (GitHub or internal) and uses the automatic close keywords.
Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

unodevops · 2024-12-06T03:07:39Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19023/index.html

unodevops · 2024-12-06T03:15:32Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19023/index.html

unodevops · 2024-12-06T05:55:33Z

⚠️⚠️ The build 149574 has failed on Uno.UI - CI.

Xiaoy312 · 2024-12-09T19:23:09Z

fixme@xy:

package diff ignore
^ ~~shouldnt need to..? rebased from 5.5 to latest, lets see if that goes away~~
^ the error arises from having miss matching signature between target-platforms (just need to remove #if __WASM__)

unodevops · 2024-12-09T22:20:52Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19023/index.html

unodevops · 2024-12-09T23:17:30Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19023/index.html

nventive-devops · 2024-12-10T05:52:02Z

The build 149827 found UI Test snapshots differences: android-28-net8: 23, android-28-net8-Snap: 59, ios: 8, ios-Snap: 46, skia-gtk-screenshots: 59, skia-linux-screenshots: 52, skia-windows-screenshots: 51, wasm: 468, wasm-automated-net9.0-UWP-Default-automated: 36, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

android-28-net8: 23 changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨
- DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
- Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
- NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic
- NavigateBackAndForthBetweenMenuItemsAndSettings_Fluent_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
- SelectionOnLoad_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsInitialLoadSelected
- SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
- WebView_NavigateToAnchor_Initial
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
- When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
- When_Click_Outside_Dialog_Expect_No_Dismiss_UITests_Shared_MessageDialogTests_MessageDialogTest
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- Detereminate_ProgressRing_Validation0_[#FF0000_#FF0000_#FF0000_#FF0000]_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIDeterminateProgressRing
- When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
android-28-net8-Snap: 59 changed over 1066
🚨🚨 Comparison Details (first 20) 🚨🚨
- Animations_DoubleAnimation_RenderTransformOrigin_GenericApp_Views_Content_UITests_Animations_DoubleAnimation_RenderTransformOrigin
- Border_Border_CornerRadius_Clipping_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_Clipping
- Border_NonUniformThicknessandRadius_Uno_UI_Samples_UITests_BorderTestsControl_NonUniformThicknessandRadius
- RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
- SwipeControl_UITests_Windows_UI_Xaml_Controls_SwipeControlTests_SwipeControl_ScrollViewer_UITests_Windows_UI_Xaml_Controls_SwipeControlTests_SwipeControl_ScrollViewer
- Animations_DoubleAnimationTestsControl_Uno_UI_Samples_Content_UITests_DoubleAnimationTestsControl
- Animations_DoubleAnimation_VisualStates_Uno_UI_Samples_Content_UITests_Animations_DoubleAnimation_VisualStates
- Border_OnepxThicknessandRadius_Uno_UI_Samples_UITests_BorderTestsControl_OnepxThicknessandRadius
- Animations_DoubleAnimation_Cumulative_Uno_UI_Samples_Content_UITests_Animations_DoubleAnimation_Cumulative
- AutoSuggestBox_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion_UITests_Shared_Windows_UI_Xaml_Controls_AutoSuggestBoxTests_AutoSuggestBoxChosenSuggestion
- Border_Border_CornerRadius_Alignments_Uno_UI_Samples_UITests_BorderTestsControl_Border_CornerRadius_Alignments
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller
- ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
- Border_BorderTopwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderTopwithmargins
- Border_SimplewithNonUnifmormRadius_Uno_UI_Samples_UITests_BorderTestsControl_SimplewithNonUnifmormRadius
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- MUX_TwoPaneView_UITests_Shared_Microsoft_UI_Xaml_Controls_TwoPaneViewTests_TwoPaneViewPage
ios: 8 changed over 267
🚨🚨 Comparison Details (first 20) 🚨🚨
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- Check_ListView_Swallows_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
- When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
ios-Snap: 46 changed over 1057
🚨🚨 Comparison Details (first 20) 🚨🚨
- Icons_UITests_Windows_UI_Xaml_Controls_SymbolIconTests_SymbolIcon_Generic_UITests_Windows_UI_Xaml_Controls_SymbolIconTests_SymbolIcon_Generic
- Icons_Uno_UI_Samples_Content_UITests_FontIconTests_FontIconControlTest_Uno_UI_Samples_Content_UITests_FontIconTests_FontIconControlTest
- ListView_ListViewGroupedChanging_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGroupedChanging
- Grid_Grid_DataBound_ColumnRow_Definitions_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_DataBound_ColumnRow_Definitions
- Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
- SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
- Keyboard_Keyboard_Showing_Dismissal_UITests_Shared_Windows_UI_Xaml_Input_Keyboard_Keyboard_Showing_Dismissal
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Brushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform
- ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage
- Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
- Clipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl
- Brushes_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransform
- Grid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
- ListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image
- MUX_MUXControlsTestApp_DropDownButtonPage_MUXControlsTestApp_DropDownButtonPage
- Image_Image_Stretch_Full_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Full_Taller
skia-gtk-screenshots: 59 changed over 2232
🚨🚨 Comparison Details (first 20) 🚨🚨
- ListViewHeaderUpdate.png-dark
- ListViewHeaderUpdate.png
- DisplayInformation.png-dark
- DisplayInformation.png
- ExpanderColorValidationPage.png-dark
- NetworkInformation.png-dark
- ClipboardTests.png
- Gamepad_Enumeration.png-dark
- Gamepad_Enumeration.png
- ContentPresenter_NativeEmbedding.png-dark
- ContentPresenter_NativeEmbedding.png
- ExpanderColorValidationPage.png
- DropDownButtonPage.png-dark
- Rectangle.png-dark
- Rectangle.png
- UIElement_Layout_Bug2879.png-dark
- UIElement_Layout_Bug2879.png
- ButtonClippingTestsControl.png-dark
- ButtonClippingTestsControl.png
- PasswordBox_AutoFill.png-dark
skia-linux-screenshots: 52 changed over 2232
🚨🚨 Comparison Details (first 20) 🚨🚨
- Buttons.png-dark
- DisplayInformation.png-dark
- DisplayInformation.png
- Ellipse.png-dark
- Ellipse.png
- Focus_FocusVisual_Properties.png-dark
- ClipboardTests.png-dark
- ClipboardTests.png
- Gamepad_CurrentReading.png-dark
- ImageBrushAlignmentXY2.png-dark
- ImageBrushAlignmentXY2.png
- DropDownButtonPage.png-dark
- Image_Stretch_None.png-dark
- Image_Stretch_None.png
- Gamepad_Enumeration.png-dark
- Gamepad_Enumeration.png
- ButtonClippingTestsControl.png-dark
- DoubleImageBrushInList.png-dark
- DoubleImageBrushInList.png
- ImageIconPage.png-dark
skia-windows-screenshots: 51 changed over 2232
🚨🚨 Comparison Details (first 20) 🚨🚨
- ButtonClippingTestsControl.png-dark
- ButtonClippingTestsControl.png
- Buttons.png-dark
- Buttons.png
- Gamepad_Enumeration.png-dark
- Gamepad_Enumeration.png
- DisplayInformation.png-dark
- DisplayInformation.png
- CalendarView_Theming.png-dark
- ImageBrush_UniformToFill.png-dark
- ImageBrush_UniformToFill.png
- ClipboardTests.png-dark
- DropDownButtonPage.png-dark
- DropDownButtonPage.png
- ImageIconPage.png-dark
- ClipboardTests.png
- BorderImageBrush.png-dark
- DoubleImageBrushInList.png-dark
- DoubleImageBrushInList.png
- Focus_FocusVisual_Properties.png-dark
wasm: 468 changed over 1043
🚨🚨 Comparison Details (first 20) 🚨🚨
- MUXControlsTestApp.RadialGradientBrushPage
- MUXControlsTestApp.RefreshContainerOnImagePage
- nVentive.Umbrella.Views.UI.Samples.Content.UITests.ButtonTestsControl.Hyperlink_Disabled
- SamplesApp.Samples.Windows_UI_Xaml_Controls.NavigationViewTests.NavigationView_Pane_Automated
- SamplesApp.Wasm.Windows_UI_Xaml_Media.Transform.Border_With_Off_Centre_RotateTransform
- SamplesApp.Wasm.Windows_UI_Xaml_Media.Transform.Border_With_Off_Centre_ScaleTransform
- SamplesApp.Windows_UI_Xaml_Controls.ListView.HorizontalListViewImage
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewItem_PressedState
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.StretchUniformAutoSize
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.StretchUniformToFill
- UITests.Shared.Windows_UI_Xaml_Controls.Button.Button_UseUWPDefaultStyles
- UITests.Shared.Windows_UI_Xaml_Controls.Button.RadioButton_Combined_Style
- UITests.Shared.Windows_UI_Xaml_Controls.Button.RadioButton_Pressed
- UITests.Toolkit.ElevationView_Clipping
- UITests.Toolkit.VisibleBoundsPadding_Modal_Test
- UITests.Windows_UI_Xaml.FocusTests.Focus_FocusVisual
- UITests.Windows_UI_Xaml.FocusTests.Focus_FocusVisual_Properties
- UITests.Windows_UI_Xaml_Controls.CommandBar.LongTitle.CommandBar_Frame
- UITests.Windows_UI_Xaml_Controls.ContentDialogTests.ContentDialog_Dialogs
- UITests.Windows_UI_Xaml_Controls.LoopingSelectorTests.LoopingSelector_Items
wasm-automated-net9.0-UWP-Default-automated: 36 changed over 1946
🚨🚨 Comparison Details (first 20) 🚨🚨
- Image_Image_Stretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- Default_StrokeThickness_MyEllipse
- Default_Uno_UI_Samples_UITests_Image_Image_Margin_Uno_UI_Samples_UITests_Image_Image_Margin
- Pointers_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroup_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroup
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
- MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
- MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- Grid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Path_Path_Dynamic_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Dynamic
- Path_Path_Geometry_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Geometry
- Clipping_UITests_Windows_UI_Xaml_Clipping_BorderVisualClipping_UITests_Windows_UI_Xaml_Clipping_BorderVisualClipping
- Default_StrokeThickness_MyPath
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Dynamic_Geometries_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Dynamic_Geometries
- Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_EllipseGeometry_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_EllipseGeometry
wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1
wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

unodevops · 2024-12-10T09:00:28Z

⚠️⚠️ The build 149827 has failed on Uno.UI - CI.

src/Uno.UI/FeatureConfiguration.cs

src/Uno.UI/UI/Xaml/Shapes/Shape.wasm.cs

unodevops · 2024-12-10T18:30:06Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19023/index.html

unodevops · 2024-12-10T19:36:17Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19023/index.html

unodevops · 2024-12-10T21:11:35Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19023/index.html

unodevops · 2024-12-10T22:05:16Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19023/index.html

unodevops · 2024-12-11T00:40:24Z

⚠️⚠️ The build 149969 has failed on Uno.UI - CI.

nventive-devops · 2024-12-11T13:54:51Z

The build 149969 found UI Test snapshots differences: android-28-net8: 24, android-28-net8-Snap: 53, ios: 9, ios-Snap: 48, skia-gtk-screenshots: 62, skia-linux-screenshots: 55, skia-windows-screenshots: 76, wasm: 412, wasm-automated-net9.0-UWP-Default-automated: 24, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

android-28-net8: 24 changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨
- Button_IsOpacity_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Button_Opacity_Automated
- Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
- NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- WebView_NavigateToLongString_AfterSuccess
- UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- When_Clip_Is_Set_On_Child_Element_original
- When_Clip_Is_Set_On_Child_Element_UITests_Windows_UI_Xaml_UIElementTests_UIElement_Clipping
- When_Clip_Is_Set_On_Child_Element_validation
- DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- DoesNotInterfereWithHorizontalDrag_UITests_Microsoft_UI_Xaml_Controls_RefreshContainerTests_RefreshContainerHorizontalScroll
- When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
android-28-net8-Snap: 53 changed over 1066
🚨🚨 Comparison Details (first 20) 🚨🚨
- TextBlock_Progressing_TextBlock_with_margin_Uno_UI_Samples_Content_UITests_TextBlockControl_Progressing_TextBlock_with_margin
- Border_SimplewithNonUnifmormRadius_Uno_UI_Samples_UITests_BorderTestsControl_SimplewithNonUnifmormRadius
- Icons_UITests_Windows_UI_Xaml_Controls_SymbolIconTests_SymbolIcon_Generic_UITests_Windows_UI_Xaml_Controls_SymbolIconTests_SymbolIcon_Generic
- TextBlock_Simple_Contrained_Horizontal_Center_Wrap2_Uno_UI_Samples_Content_UITests_TextBlockControl_Simple_Contrained_Horizontal_Center_Wrap2
- TextBlock_Simple_Text_Uno_UI_Samples_Content_UITests_TextBlockControl_Simple_Text
- Border_BorderBottomwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderBottomwithmargins
- Border_NonUniformThicknessandRadius_Uno_UI_Samples_UITests_BorderTestsControl_NonUniformThicknessandRadius
- Border_BorderTopwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderTopwithmargins
- Border_Simple_with_Radius_Uno_UI_Samples_UITests_BorderTestsControl_Simple_with_Radius
- Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
- Border_Border_CornerRadius_BorderThickness_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_BorderThickness
- GridView_Uno_UI_Samples_Content_UITests_GridView_GridViewScrollIntoViewTest_Uno_UI_Samples_Content_UITests_GridView_GridViewScrollIntoViewTest
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Border_OnepxThicknessandRadiusAndTextBlock_Uno_UI_Samples_UITests_BorderTestsControl_OnepxThicknessandRadiusAndTextBlock
- ListView_ListView_FirstLastCacheIndex_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_FirstLastCacheIndex
- Scrolling_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage
- TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout
- Border_Circle_Uno_UI_Samples_UITests_BorderTestsControl_Circle
- MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- MUX_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonTestsPage
ios: 9 changed over 267
🚨🚨 Comparison Details (first 20) 🚨🚨
- When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
ios-Snap: 48 changed over 1057
🚨🚨 Comparison Details (first 20) 🚨🚨
- ContentControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParent
- Keyboard_Keyboard_Showing_Dismissal_UITests_Shared_Windows_UI_Xaml_Input_Keyboard_Keyboard_Showing_Dismissal
- ListView_HorizontalListView_Padding_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Padding
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- MUX_MUXControlsTestApp_DropDownButtonPage_MUXControlsTestApp_DropDownButtonPage
- Brushes_ImageBrushWithCompositeTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithCompositeTransform
- ListView_ListViewGroupedChanging_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGroupedChanging
- ListView_ListView_TextBox_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_TextBox
- NavigationView_MUXControlsTestApp_NavigationViewMenuItemStretchPage_MUXControlsTestApp_NavigationViewMenuItemStretchPage
- Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse
- Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
- TextBlock_Attributed_text_FontSize_Changing_Uno_UI_Samples_Content_UITests_TextBlockControl_Attributed_text_FontSize_Changing
- Grid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
- ListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image
- SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
- TextBlock_TextBoxSizeChanging_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBoxSizeChanging
- Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush
- Grid_Grid_DataBound_ColumnRow_Definitions_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_DataBound_ColumnRow_Definitions
- Lottie_Lottie_Progress_UITests_Lottie_LottieProgressPage
- Buttons_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
skia-gtk-screenshots: 62 changed over 2230
🚨🚨 Comparison Details (first 20) 🚨🚨
- ImageBrushInList.png-dark
- ImageBrushInList.png
- Rectangle.png-dark
- Rectangle.png
- DropDownButtonPage.png-dark
- DropDownButtonPage.png
- ExpanderColorValidationPage.png-dark
- ExpanderColorValidationPage.png
- ListViewHeaderUpdate.png-dark
- ListViewHeaderUpdate.png
- ContentPresenter_NativeEmbedding.png-dark
- ContentPresenter_NativeEmbedding.png
- NetworkInformation.png-dark
- NetworkInformation.png
- UIElement_Layout_Bug2879.png-dark
- UIElement_Layout_Bug2879.png
- DisplayInformation.png-dark
- DisplayInformation.png
- Popup_Simple.png-dark
- Popup_Simple.png
skia-linux-screenshots: 55 changed over 2230
🚨🚨 Comparison Details (first 20) 🚨🚨
- Ellipse.png-dark
- Ellipse.png
- Buttons.png-dark
- Buttons.png
- BorderImageBrush.png
- Examples.png
- ClipboardTests.png-dark
- DropDownButtonPage.png-dark
- Focus_FocusVisual_Properties.png
- Image_UseTargetSize.png-dark
- Image_UseTargetSize.png
- ButtonClippingTestsControl.png-dark
- ImageBrushInList.png-dark
- ImageBrushInList.png
- DoubleImageBrushInList.png-dark
- DoubleImageBrushInList.png
- ImageIconPage.png-dark
- ImageIconPage.png
- ClipboardTests.png
- DisplayInformation.png-dark
skia-windows-screenshots: 76 changed over 2230
🚨🚨 Comparison Details (first 20) 🚨🚨
- BorderImageBrushRelativeTransform.png-dark
- ButtonClippingTestsControl.png-dark
- ButtonClippingTestsControl.png
- Ellipse.png-dark
- Ellipse.png
- ImageBrushInList.png-dark
- ImageBrushInList.png
- Gamepad_Enumeration.png-dark
- Gamepad_Enumeration.png
- ImagesInlineInFlipView.png-dark
- ImagesInlineInFlipView.png
- Buttons.png-dark
- Buttons.png
- Image_UseTargetSize.png-dark
- Image_UseTargetSize.png
- Examples.png
- BorderImageBrushRelativeTransform.png
- ClipboardTests.png-dark
- ClipboardTests.png
- ColorPickerSample.png-dark
wasm: 412 changed over 1043
🚨🚨 Comparison Details (first 20) 🚨🚨
- MUXControlsTestApp.NavigationViewTopNavPage
- MUXControlsTestApp.SwipeControlPage
- MUXControlsTestApp.SwipeControlPage2
- SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_NavigateToUri
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_Header
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewWithinScollViewer
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.Path_Dynamic
- UITests.Microsoft_UI_Xaml_Controls.RatingControlTests.RatingControlPage
- UITests.Shared.Windows_System.Profile.AnalyticsInfoTests
- UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_Explicit_Items
- UITests.Shared.Windows_UI_Xaml_Input.Pointers.DragCoordinates_Automated
- UITests.Shared.Windows_UI_Xaml_Input.RoutedEvents.RoutedEvent_DoubleTapped
- UITests.Shared.Windows_UI_Xaml_Input.RoutedEvents.RoutedEvent_Focus
- UITests.Shared.Windows_UI_Xaml_Input.RoutedEvents.RoutedEvent_Pointer
- UITests.Windows_UI_ViewManagement.ApplicationViewSizing
- UITests.Windows_UI_ViewManagement.ApplicationViewSpanningRectsPage
- UITests.Windows_UI_Xaml_Controls.CommandBar.BackButtonTitle.CommandBar_Frame
- UITests.Windows_UI_Xaml_Controls.CommandBar.CommandBar_Native_Frame
- UITests.Windows_UI_Xaml_Controls.RelativePanelTests.RelativePanel_AlignHorizontalVerticalCenter
- UITests.Windows_UI_Xaml_Controls.RelativePanelTests.RelativePanel_MultipleCenterAlign
wasm-automated-net9.0-UWP-Default-automated: 24 changed over 1946
🚨🚨 Comparison Details (first 20) 🚨🚨
- Affect_Measurement_polyline_PolylinePage_-_ClearShape
- Default_StrokeThickness_MyLine
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Affect_Measurement_polygon_PolygonPage_-_ClearShape
- Default_StrokeThickness_MyPolyline
- Default_StrokeThickness_MyRect
- Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
- MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- DatePicker_Flyout_DatePicker_-_Flyout
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic
- TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
- Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1
wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

jeromelaban · 2024-12-11T16:38:35Z

@Mergifyio backport release/stable/5.5

jeromelaban · 2024-12-11T16:38:38Z

@Mergifyio backport release/stable/5.4

mergify · 2024-12-11T16:49:43Z

backport release/stable/5.5

✅ Backports have been created

#19063 refactor: shape perf (backport #19023) has been created for branch release/stable/5.5

mergify · 2024-12-11T16:49:44Z

backport release/stable/5.4

✅ Backports have been created

#19064 refactor: shape perf (backport #19023) has been created for branch release/stable/5.4

…5.4/pr-19023 refactor: shape perf (backport #19023)

…5.5/pr-19023 refactor: shape perf (backport #19023)

github-actions bot added the platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform label Dec 6, 2024

Xiaoy312 force-pushed the dev/xygu/20241205/shape-perf branch from 76d93ed to 852daf8 Compare December 9, 2024 18:58

Xiaoy312 force-pushed the dev/xygu/20241205/shape-perf branch from 852daf8 to 52c4fc4 Compare December 9, 2024 20:01

jeromelaban reviewed Dec 10, 2024

View reviewed changes

src/Uno.UI/FeatureConfiguration.cs Outdated Show resolved Hide resolved

src/Uno.UI/UI/Xaml/Shapes/Shape.wasm.cs Outdated Show resolved Hide resolved

Xiaoy312 force-pushed the dev/xygu/20241205/shape-perf branch from 52c4fc4 to cdd9db2 Compare December 10, 2024 17:32

Xiaoy312 requested a review from jeromelaban December 10, 2024 17:34

Xiaoy312 force-pushed the dev/xygu/20241205/shape-perf branch 2 times, most recently from 78a9f5e to 0817f4a Compare December 10, 2024 17:42

Xiaoy312 commented Dec 10, 2024

View reviewed changes

src/Uno.UI/UI/Xaml/Shapes/Shape.wasm.cs Outdated Show resolved Hide resolved

Xiaoy312 marked this pull request as ready for review December 10, 2024 17:43

Xiaoy312 requested a review from ebariche December 10, 2024 17:50

refactor(shape): wasm shape perf

338b32d

Xiaoy312 force-pushed the dev/xygu/20241205/shape-perf branch from 0817f4a to 338b32d Compare December 10, 2024 20:40

jeromelaban approved these changes Dec 11, 2024

View reviewed changes

jeromelaban enabled auto-merge December 11, 2024 12:59

jeromelaban merged commit 826aac9 into master Dec 11, 2024
114 checks passed

jeromelaban deleted the dev/xygu/20241205/shape-perf branch December 11, 2024 14:04

This was referenced Dec 11, 2024

refactor: shape perf (backport #19023) #19063

Merged

refactor: shape perf (backport #19023) #19064

Merged

jeromelaban added a commit that referenced this pull request Dec 11, 2024

Merge pull request #19064 from unoplatform/mergify/bp/release/stable/…

f4e5109

…5.4/pr-19023 refactor: shape perf (backport #19023)

jeromelaban added a commit that referenced this pull request Dec 11, 2024

Merge pull request #19063 from unoplatform/mergify/bp/release/stable/…

d9bc2e2

…5.5/pr-19023 refactor: shape perf (backport #19023)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: shape perf #19023

refactor: shape perf #19023

Xiaoy312 commented Dec 6, 2024

unodevops commented Dec 6, 2024

unodevops commented Dec 6, 2024

unodevops commented Dec 6, 2024

Xiaoy312 commented Dec 9, 2024 •

edited

Loading

unodevops commented Dec 9, 2024

unodevops commented Dec 9, 2024

nventive-devops commented Dec 10, 2024

unodevops commented Dec 10, 2024

unodevops commented Dec 10, 2024

unodevops commented Dec 10, 2024

unodevops commented Dec 10, 2024

unodevops commented Dec 10, 2024

unodevops commented Dec 11, 2024

nventive-devops commented Dec 11, 2024

jeromelaban commented Dec 11, 2024

jeromelaban commented Dec 11, 2024

mergify bot commented Dec 11, 2024 •

edited

Loading

mergify bot commented Dec 11, 2024 •

edited

Loading

refactor: shape perf #19023

refactor: shape perf #19023

Conversation

Xiaoy312 commented Dec 6, 2024

PR Type

What is the current behavior?

What is the new behavior?

PR Checklist

Other information

unodevops commented Dec 6, 2024

unodevops commented Dec 6, 2024

unodevops commented Dec 6, 2024

Xiaoy312 commented Dec 9, 2024 • edited Loading

unodevops commented Dec 9, 2024

unodevops commented Dec 9, 2024

nventive-devops commented Dec 10, 2024

unodevops commented Dec 10, 2024

unodevops commented Dec 10, 2024

unodevops commented Dec 10, 2024

unodevops commented Dec 10, 2024

unodevops commented Dec 10, 2024

unodevops commented Dec 11, 2024

nventive-devops commented Dec 11, 2024

jeromelaban commented Dec 11, 2024

jeromelaban commented Dec 11, 2024

mergify bot commented Dec 11, 2024 • edited Loading

✅ Backports have been created

mergify bot commented Dec 11, 2024 • edited Loading

✅ Backports have been created

Xiaoy312 commented Dec 9, 2024 •

edited

Loading

mergify bot commented Dec 11, 2024 •

edited

Loading

mergify bot commented Dec 11, 2024 •

edited

Loading