Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hr): Improve retry logic when using UpdateFile in case of NoChanges #19005

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(hr): Improve retry logic when using UpdateFile in case of NoChanges #19005

merged 1 commit into from
Dec 11, 2024

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Dec 4, 2024

Bugfix

Improve retry logic when using UpdateFile in case of NoChanges

What is the current behavior?

We might get a NoChnages when there are actual changes pending

What is the new behavior?

We retry more and longer ... and app can customize the retry logic if needed

PR Checklist

Please check if your PR fulfills the following requirements:

@dr1rrb dr1rrb enabled auto-merge December 4, 2024 16:48
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19005/index.html

ajpinedam
ajpinedam approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@ajpinedam ajpinedam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@jeromelaban
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19005/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19005/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 149414 has failed on Uno.UI - CI.

@nventive-devops
Copy link
Contributor

The build 149414 found UI Test snapshots differences: android-28-net8: 23, android-28-net8-Snap: 49, ios: 9, ios-Snap: 56, skia-gtk-screenshots: 56, skia-linux-screenshots: 64, skia-windows-screenshots: 75, wasm: 249, wasm-automated-net9.0-UWP-Default-automated: 198, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

  • android-28-net8: 23 changed over 829

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Button_IsOpacity_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Button_Opacity_Automated
    • DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
    • DoesNotInterfereWithHorizontalDrag_UITests_Microsoft_UI_Xaml_Controls_RefreshContainerTests_RefreshContainerHorizontalScroll
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
    • When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
    • When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
    • NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Dynamic
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • When_Clip_Is_Set_On_Child_Element_original
    • When_Clip_Is_Set_On_Child_Element_UITests_Windows_UI_Xaml_UIElementTests_UIElement_Clipping
    • When_Clip_Is_Set_On_Child_Element_validation

  • android-28-net8-Snap: 49 changed over 1066

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ListView_ListView_OwnContainer_Virtualized_UITests_Shared_Windows_UI_Xaml_Controls_ListView_OwnContainer_Virtualized
    • Grid_Grid_with_OutOfRange_Cells_UITests_Shared_Windows_UI_Xaml_Controls_GridTestsControl_Grid_with_OutOfRange_Cells
    • Icons_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground
    • ListView_HorizontalListView_Templates_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListView_Templates
    • ListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image
    • ListView_ListView_Infinite_Breadth_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_Infinite_Breadth
    • TabView_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage_UITests_Microsoft_UI_Xaml_Controls_TabViewTests_TabViewPage
    • Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
    • ListView_ListView_Snap_Rubberband_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Snap_Rubberband
    • NavigationView_MUXControlsTestApp_NavigationViewRS4Page_MUXControlsTestApp_NavigationViewRS4Page
    • NavigationView_MUXControlsTestApp_NavigationViewSelectedItemEdgeCasePage_MUXControlsTestApp_NavigationViewSelectedItemEdgeCasePage
    • NavigationView_MUXControlsTestApp_NavigationViewTopNavOnlyPage_MUXControlsTestApp_NavigationViewTopNavOnlyPage
    • SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
    • TextBlock_Progressing_TextBlock_with_margin_Uno_UI_Samples_Content_UITests_TextBlockControl_Progressing_TextBlock_with_margin
    • ListView_ListView_FirstLastCacheIndex_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_FirstLastCacheIndex
    • MUX_MUXControlsTestApp_PersonPicturePage_MUXControlsTestApp_PersonPicturePage
    • MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
    • TextBlock_Simple_Contrained_Horizontal_Center_Wrap2_Uno_UI_Samples_Content_UITests_TextBlockControl_Simple_Contrained_Horizontal_Center_Wrap2
    • Scrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPage

  • ios: 9 changed over 267

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ImageStretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • Validate_Offscreen_Shapes_UITests_Windows_UI_Xaml_Shapes_Offscreen_Shapes
    • When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
    • When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers

  • ios-Snap: 56 changed over 1057

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Brushes_UITests_Windows_UI_Xaml_Media_BrushesTests_CompositionNineGridBrush_Source_Changes_UITests_Windows_UI_Xaml_Media_BrushesTests_CompositionNineGridBrush_Source_Changes
    • Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
    • ContentControl_ContentControl_Nested_TemplatedParent_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Nested_TemplatedParent
    • Image_EmptyImageFixedWidth_Uno_UI_Samples_UITests_ImageTestsControl_EmptyImageFixedWidth
    • Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream
    • ListView_ListViewHeaderFooter_ImplicitlyBinded_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewHeaderFooter_ImplicitlyBinded
    • MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • TextBlock_TextBlockMultilineInStarStackPanel_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockMultilineInStarStackPanel
    • ContentControl_ContentControl_UnsetContent_GenericApp_Views_Content_UITests_ContentControlTestsControl_ContentControl_UnsetContent
    • Grid_Grid_DataBound_ColumnRow_Definitions_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_DataBound_ColumnRow_Definitions
    • MUX_MUXControlsTestApp_PersonPicturePage_MUXControlsTestApp_PersonPicturePage
    • Focus_FocusManagerTest_Uno_UI_Samples_Content_UITests_FocusTests_FocusManagerTest
    • ListView_ListView_TextBox_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_TextBox
    • NavigationView_MUXControlsTestApp_NavigationViewMenuItemStretchPage_MUXControlsTestApp_NavigationViewMenuItemStretchPage
    • MUX_MUXControlsTestApp_DropDownButtonPage_MUXControlsTestApp_DropDownButtonPage
    • Lottie_Lottie_Progress_UITests_Lottie_LottieProgressPage
    • TextBlock_TextBlock_FixedWidth_With_DataBound_Run_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_FixedWidth_With_DataBound_Run
    • Brushes_PathImageBrushfill_Uno_UI_Samples_UITests_ImageBrushTestControl_PathImageBrushfill
    • Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal
    • Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical

  • skia-gtk-screenshots: 56 changed over 2232

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • DragDrop_TestPage.png-dark
    • DragDrop_TestPage.png
    • ListViewHeaderUpdate.png-dark
    • ListViewHeaderUpdate.png
    • ImageBrushInList.png
    • NetworkInformation.png-dark
    • NetworkInformation.png
    • UIElement_Layout_Bug2879.png-dark
    • UIElement_Layout_Bug2879.png
    • ClipboardTests.png-dark
    • ClipboardTests.png
    • ExpanderColorValidationPage.png-dark
    • ExpanderColorValidationPage.png
    • ContentPresenter_NativeEmbedding.png-dark
    • ContentPresenter_NativeEmbedding.png
    • PasswordBox_AutoFill.png-dark
    • PasswordBox_AutoFill.png
    • Gamepad_Enumeration.png-dark
    • Gamepad_Enumeration.png
    • DropDownButtonPage.png

  • skia-linux-screenshots: 64 changed over 2232

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • BorderImageBrush.png-dark
    • BorderImageBrush.png
    • ButtonClippingTestsControl.png-dark
    • CalendarView_Theming.png
    • ImageInStackPanel.png-dark
    • ImageInStackPanel.png
    • DropDownButtonPage.png-dark
    • DropDownButtonPage.png
    • Image_UseTargetSize.png-dark
    • Image_UseTargetSize.png
    • DisplayInformation.png-dark
    • DisplayInformation.png
    • Ellipse.png-dark
    • Ellipse.png
    • ImagesInlineInFlipView.png-dark
    • ImagesInlineInFlipView.png
    • Focus_FocusVisual_Properties.png-dark
    • Gamepad_CurrentReading.png-dark
    • ClipboardTests.png
    • DragDrop_TestPage.png-dark

  • skia-windows-screenshots: 75 changed over 2232

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Examples.png
    • ExpanderColorValidationPage.png-dark
    • ExpanderColorValidationPage.png
    • CalendarView_Theming.png-dark
    • CalendarView_Theming.png
    • Buttons.png
    • DropDownButtonPage.png-dark
    • DropDownButtonPage.png
    • BorderImageBrushRelativeTransform.png-dark
    • BorderImageBrushRelativeTransform.png
    • Focus_FocusVisual_Properties.png-dark
    • Focus_FocusVisual_Properties.png
    • ImageBrushInList.png-dark
    • ImageBrushInList.png
    • ImageIconPage.png-dark
    • ImageIconPage.png
    • ButtonClippingTestsControl.png-dark
    • ClipboardTests.png-dark
    • ClipboardTests.png
    • Image_UseTargetSize.png-dark

  • wasm: 249 changed over 1043

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MUXControlsTestApp.DropDownButtonPage
    • MUXControlsTestApp.RadialGradientBrushPage
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_FullScreen_Popup
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.HorizontalListView_Padding
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Inside_ListView
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_ItemClick
    • UITests.Shared.Windows_UI_Xaml_Controls.Flyout.Flyout_OverlayInputPassThroughElement
    • UITests.Shared.Windows_UI_Xaml_Controls.Flyout.Flyout_Transforms_On_Target
    • UITests.Shared.Windows_UI_Xaml_Controls.Flyout.Flyout_Unloaded
    • UITests.Uno_Web.Http.CookieManagerTests
    • UITests.Windows_UI_Xaml_Controls.ImageTests.BitmapImage_vs_SvgImageSource
    • UITests.Windows_UI_Xaml_Controls.ImageTests.ImageSourceUrlMsAppDataScheme
    • MUXControlsTestApp.NavigationViewTopNavOverflowButtonPage
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_Corners
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_Empty
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_ScrollViewer
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_SelectedItem
    • SamplesApp.Windows_UI_Xaml.Clipping.XamlButtonWithClipping
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewGroupedLargeLegacy
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewGroupedVariableHeightComplexTemplate

  • wasm-automated-net9.0-UWP-Default-automated: 198 changed over 1946

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • BitmapImage_vs_SvgImageSource_BitmapLocal_UITests_Windows_UI_Xaml_Controls_ImageTests_BitmapImage_vs_SvgImageSource
    • FocusManager_GetFocusedElement_ComboBoxItem_Validation_FocusManager_-_GetFocusedElement_-_ComboBoxItem_-_2_-_After_Selection
    • FocusManager_GetFocusedElement_ComboBoxItem_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
    • FocusManager_GetFocusedElement_ComboBox_LostFocus_Validation_FocusManager_-_LostFocus_-_ComboBox_-_1_-_Initial_State
    • FocusManager_GetFocusedElement_ComboBox_LostFocus_Validation_FocusManager_-_LostFocus_-_ComboBox_-_2_-_Click_outside
    • ListView_ListView_ItemsPanel_HotSwap_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_ItemsPanel_HotSwap
    • BitmapImage_vs_SvgImageSource_BitmapLocal_url_local
    • Default_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_IsTabStop_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_IsTabStop
    • FocusManager_GetFocusedElement_HyperlinkButton_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
    • FocusManager_GetFocusedElement_Image_Validation_FocusManager_-_GetFocusedElement_-_Image_-_1_-_Initial_State
    • FocusManager_GetFocusedElement_Image_Validation_FocusManager_-_GetFocusedElement_-_Image_-_2_-_After_Selection
    • FocusManager_GetFocusedElement_Image_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
    • BitmapImage_vs_SvgImageSource_SvgRemote_url_stream
    • BitmapImage_vs_SvgImageSource_BitmapRemote_url_direct
    • Buttons_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
    • Control_BasicEnability_UITests_Shared_Windows_UI_Xaml_Enability_BasicEnability
    • FocusManager_GetFocusedElement_Grid_Validation_FocusManager_-_GetFocusedElement_-_Grid_-_1_-_Initial_State
    • FocusManager_GetFocusedElement_Grid_Validation_FocusManager_-_GetFocusedElement_-_Grid_-_2_-_After_Selection
    • FocusManager_GetFocusedElement_Grid_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_GetFocus_Automated
    • FocusManager_GetFocusedElement_ListViewItem_Validation_FocusManager_-_GetFocusedElement_-_ListViewItem_-_2_-_After_Selection

  • wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1

  • wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

@dr1rrb dr1rrb merged commit d1aeac1 into master Dec 11, 2024
115 checks passed
@dr1rrb dr1rrb deleted the dev/dr/hrRetry branch December 11, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpinedam ajpinedam ajpinedam approved these changes

@nickrandolph nickrandolph nickrandolph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dr1rrb @unodevops @jeromelaban @nventive-devops @nickrandolph @ajpinedam