You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@MartinZikmund Not a comment for the PR directly, but would it be possible to encrypt the data on WASM before storing on our side? When users would use this API it would store to the same local storage, but it would be at least automatically encrypted.
@morning4coffe-dev unfortunately not, it is all on client side, so it would not be possible to encrypt securely in any way - as long as the app would be able to decrypt (and it has to for it to be useful), anyone with the assemblies in hand could too
area/skia ✏️Categorizes an issue or PR as relevant to Skiaplatform/android 🤖Categorizes an issue or PR as relevant to the Android platformplatform/ios 🍎Categorizes an issue or PR as relevant to the iOS platformplatform/macos 🍏Categorizes an issue or PR as relevant to the macOS platformplatform/wasm 🌐Categorizes an issue or PR as relevant to the WebAssembly platform
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
platform/wasm 🌐
MartinZikmund
force-pushed
the
dev/mazi/istypepresent
branch
from
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
PasswordVaultis always underlined as not implemented.What is the new behavior?
Underlined only on Skia & WASM
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.