`Frame` should throw on page exceptions #18983

MartinZikmund · 2024-12-02T16:05:14Z

…avigateGitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

Bugfix

What is the current behavior?

In WinUI, exceptions thrown on Page instances propagate to corresponding Frame.Navigate, but this is not the case in Uno Platform targets

What is the new behavior?

Exceptions bubble up

PR Checklist

Please check if your PR fulfills the following requirements:

Docs have been added/updated which fit documentation template (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Validated PR Screenshots Compare Test Run results.
Contains NO breaking changes
Associated with an issue (GitHub or internal) and uses the automatic close keywords.
Commits must be following the Conventional Commits specification.

Other information

Internal Issue (If applicable):

unodevops · 2024-12-02T17:49:03Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18983/index.html

unodevops · 2024-12-03T00:18:35Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18983/index.html

unodevops · 2024-12-03T01:00:51Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18983/index.html

unodevops · 2024-12-03T01:15:37Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18983/index.html

ajpinedam

🚀

unodevops · 2024-12-03T10:20:17Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18983/index.html

unodevops · 2024-12-03T10:21:05Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18983/index.html

unodevops · 2024-12-03T11:07:39Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18983/index.html

unodevops · 2024-12-03T11:09:24Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18983/index.html

unodevops · 2024-12-03T13:10:43Z

⚠️⚠️ The build 149188 has failed on Uno.UI - CI.

unodevops · 2024-12-04T13:17:03Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18983/index.html

unodevops · 2024-12-04T14:30:33Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18983/index.html

jeromelaban · 2024-12-04T21:30:46Z

/azp run

azure-pipelines · 2024-12-04T21:31:13Z

Azure Pipelines successfully started running 2 pipeline(s).

MartinZikmund · 2024-12-04T21:42:52Z

/azp run

azure-pipelines · 2024-12-04T21:43:16Z

Azure Pipelines successfully started running 2 pipeline(s).

unodevops · 2024-12-04T23:27:28Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18983/index.html

unodevops · 2024-12-05T03:39:53Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18983/index.html

unodevops · 2024-12-05T06:55:41Z

⚠️⚠️ The build 149423 has failed on Uno.UI - CI.

…avigate

unodevops · 2024-12-08T18:00:48Z

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18983/index.html

unodevops · 2024-12-08T18:36:25Z

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18983/index.html

nventive-devops · 2024-12-08T21:26:54Z

The build 149711 found UI Test snapshots differences: android-28-net8: 22, android-28-net8-Snap: 47, ios: 10, ios-Snap: 44, skia-gtk-screenshots: 66, skia-linux-screenshots: 67, skia-windows-screenshots: 67, wasm: 513, wasm-automated-net9.0-UWP-Default-automated: 33, wasm-automated-net9.0-UWP-RuntimeTests-0: 0, wasm-automated-net9.0-UWP-RuntimeTests-1: 0, wasm-automated-net9.0-UWP-RuntimeTests-2: 0, wasm-automated-net9.0-WinUI-Benchmarks-automated: 0, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

android-28-net8: 22 changed over 829
🚨🚨 Comparison Details (first 20) 🚨🚨
- DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
- Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Pivot_Non_PivotItem_Items_UITests_Shared_Windows_UI_Xaml_Controls_Pivot_Pivot_CustomContent_Automated
- NavigateBackAndForthBetweenMenuItemsAndSettings_Fluent_SamplesApp_Samples_Microsoft_UI_Xaml_Controls_NavigationViewTests_FluentStyle_FluentStyle_NavigationViewSample
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
- When_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touch
- Pivot_Non_PivotItemChange_Validation_UITests_Shared_Windows_UI_Xaml_Controls_Pivot_Pivot_CustomContent_Automated
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_BitmapIcon_Generic_Changed
- When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_BitmapIcon_Generic_Initial
- When_Tap_PressedReleasedAreHandled_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_Pointers
android-28-net8-Snap: 47 changed over 1066
🚨🚨 Comparison Details (first 20) 🚨🚨
- TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage
- Border_Border_Corner_Overlap_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerOverlap
- Brushes_UITests_Windows_UI_Xaml_Media_BrushesTests_CompositionNineGridBrush_Source_Changes_UITests_Windows_UI_Xaml_Media_BrushesTests_CompositionNineGridBrush_Source_Changes
- Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
- Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
- MediaPlayerElement_Using_3gp_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_3gp_Extension
- MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
- MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
- NavigationView_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage_MUXControlsTestApp_NavigationViewCustomThemeResourcesPage
- Border_Border_CornerRadius_BorderThickness_UITests_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_BorderThickness
- ColorPicker_ColorPickerSample_UITests_Microsoft_UI_Xaml_Controls_ColorPickerTests_ColorPickerSample
- Grid_Grid_with_OutOfRange_Cells_UITests_Shared_Windows_UI_Xaml_Controls_GridTestsControl_Grid_with_OutOfRange_Cells
- Pointers_Sequence_UITests_Shared_Windows_UI_Input_PointersTests_EventsSequences
- Scrolling_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage
- MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
- MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
- RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
- Brushes_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- TextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout
ios: 10 changed over 267
🚨🚨 Comparison Details (first 20) 🚨🚨
- ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- TextBox_UpdatedBinding_On_OneWay_Mode_UITests_Windows_UI_Xaml_Controls_TextBox_TextBox_Bindings
- When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- FocusManager_FocusDirection_Up_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection
- FocusManager_FocusDirection_Right_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
- When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
- When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
ios-Snap: 44 changed over 1057
🚨🚨 Comparison Details (first 20) 🚨🚨
- Brushes_ImageBrushWithScaleTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithScaleTransform
- Brushes_UITests_Shared_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_SameWithDelay_UITests_Shared_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_SameWithDelay
- Grid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildren
- Image_LargeImageList_Uno_UI_Samples_UITests_LargeImageList
- SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
- ListView_ListView_TextBox_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_TextBox
- ListView_ListView_TransformsOnList_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_TransformsOnList
- ListView_ListView_Image_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Image
- Default_Uno_UI_Samples_UITests_Image_Image_Margin_Uno_UI_Samples_UITests_Image_Image_Margin
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal
- Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical
- Grid_Grid_with_OutOfRange_Cells_UITests_Shared_Windows_UI_Xaml_Controls_GridTestsControl_Grid_with_OutOfRange_Cells
- MUX_MUXControlsTestApp_DropDownButtonPage_MUXControlsTestApp_DropDownButtonPage
- Brushes_ImageBrushLocalAsset_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushLocalAsset
- Brushes_UITests_Windows_UI_Xaml_Media_BrushesTests_CompositionNineGridBrush_Source_Changes_UITests_Windows_UI_Xaml_Media_BrushesTests_CompositionNineGridBrush_Source_Changes
- Focus_FocusManagerTest_Uno_UI_Samples_Content_UITests_FocusTests_FocusManagerTest
- Icons_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage_UITests_Microsoft_UI_Xaml_Controls_ImageIconTests_ImageIconPage
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Equal
- Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Smaller
skia-gtk-screenshots: 66 changed over 2232
🚨🚨 Comparison Details (first 20) 🚨🚨
- DropDownButtonPage.png-dark
- Rectangle.png-dark
- Rectangle.png
- Popup_Simple.png-dark
- Popup_Simple.png
- TransformToVisual_Translate2d.png-dark
- TransformToVisual_Translate2d.png
- ButtonClippingTestsControl.png-dark
- ButtonClippingTestsControl.png
- DropDownButtonPage.png
- NetworkInformation.png-dark
- NetworkInformation.png
- ClipboardTests.png-dark
- ClipboardTests.png
- Ellipse.png-dark
- Focus_FocusVisual_Properties.png-dark
- Ellipse.png
- Focus_FocusVisual_Properties.png
- Native.png-dark
- Native.png
skia-linux-screenshots: 67 changed over 2232
🚨🚨 Comparison Details (first 20) 🚨🚨
- CalendarView_Theming.png-dark
- CalendarView_Theming.png
- ButtonClippingTestsControl.png-dark
- DropDownButtonPage.png-dark
- Buttons.png
- DisplayInformation.png-dark
- Gamepad_Enumeration.png-dark
- Gamepad_Enumeration.png
- ImageBrushInList.png-dark
- ImageBrushInList.png
- BorderImageBrushRelativeTransform.png
- ImageBrush_UniformToFill.png-dark
- ImageBrush_UniformToFill.png
- Image_UseTargetSize.png-dark
- Image_UseTargetSize.png
- Focus_FocusVisual_Properties.png-dark
- DragDrop_TestPage.png-dark
- DragDrop_TestPage.png
- BorderImageBrushRelativeTransform.png-dark
- ClipboardTests.png-dark
skia-windows-screenshots: 67 changed over 2232
🚨🚨 Comparison Details (first 20) 🚨🚨
- CalendarView_Theming.png-dark
- CalendarView_Theming.png
- DragDrop_TestPage.png-dark
- DragDrop_TestPage.png
- BorderImageBrush.png-dark
- Buttons.png-dark
- Buttons.png
- ColorPickerSample.png-dark
- Examples.png
- ExpanderColorValidationPage.png-dark
- ExpanderColorValidationPage.png
- Gamepad_Enumeration.png-dark
- Gamepad_Enumeration.png
- BorderImageBrush.png
- ButtonClippingTestsControl.png-dark
- ButtonClippingTestsControl.png
- DisplayInformation.png-dark
- DisplayInformation.png
- DropDownButtonPage.png-dark
- DropDownButtonPage.png
wasm: 513 changed over 1043
🚨🚨 Comparison Details (first 20) 🚨🚨
- GenericApp.Views.Content.UITests.ContentControlTestsControl.ContentControl_UnsetContent
- SamplesApp.Samples.Microsoft_UI_Xaml_Controls.NavigationViewTests.FluentStyle.FluentStyle_NavigationViewSample
- SamplesApp.Wasm.Windows_UI_Xaml_Controls.ComboBox.ComboBox_ItemsSource
- SamplesApp.Wasm.Windows_UI_Xaml_Media.Transform.TransformToVisual_Translate2d
- SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewLarge
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.Invisible
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.StretchNoneVerticalAlignmentCenter
- SamplesApp.Windows_UI_Xaml_Shapes.PathTestsControl.StretchUniform
- UITests.Microsoft_UI_Xaml_Controls.InfoBadgeTests.InfoBadgePage
- UITests.Microsoft_UI_Xaml_Controls.NumberBoxTests.NumberBox_ExpressionTest
- UITests.Shared.Windows_Devices.Midi.MidiDeviceOutputTests
- UITests.Shared.Windows_Phone.Devices_Notifications_VibrationDevice
- UITests.Shared.Windows_UI_Xaml_Controls.ContentPresenter.ContentPresenter_ImplicitContent
- UITests.Shared.Windows_UI_Xaml_Controls.Flyout.Flyout_ButtonInContent
- UITests.Shared.Windows_UI_Xaml_Controls.TextBoxTests.TextBox_BeforeTextChanging
- UITests.Shared.Windows_UI_Xaml_Controls.TextBoxTests.TextBox_CharacterCasing
- UITests.Shared.Windows_UI_Xaml_Controls.TextBoxTests.TextBox_Disabled
- UITests.Shared.Windows_UI_Xaml_Controls.TextBoxTests.TextBox_Formatting_Flicker
- UITests.Windows_Networking.NetworkInformationTests
- UITests.Windows_UI_Xaml_Controls.ImageTests.Image_Transforms
wasm-automated-net9.0-UWP-Default-automated: 33 changed over 1946
🚨🚨 Comparison Details (first 20) 🚨🚨
- Expander_WinUIExpanderPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_WinUIExpanderPage
- Grid_Grid_with_OutOfRange_Cells_UITests_Shared_Windows_UI_Xaml_Controls_GridTestsControl_Grid_with_OutOfRange_Cells
- ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
- Brushes_UITests_Windows_UI_Xaml_Media_BrushesTests_CompositionNineGridBrush_Source_Changes_UITests_Windows_UI_Xaml_Media_BrushesTests_CompositionNineGridBrush_Source_Changes
- Default_StrokeThickness_MyRect
- Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
- Default_StrokeThickness_MyRect_0_StrokeThickness
- Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
- Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
- Default_StrokeThickness_MyPolygon_0_StrokeThickness
- Default_StrokeThickness_MyPolyline
- Default_StrokeThickness_MyEllipse_0_StrokeThickness
- Default_StrokeThickness_MyPath
- ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
- Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
- WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_Basic
- When_HollowCircle2_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroup
- SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
- TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
wasm-automated-net9.0-UWP-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-UWP-RuntimeTests-2: 0 changed over 1
wasm-automated-net9.0-WinUI-Benchmarks-automated: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1
wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

MartinZikmund self-assigned this Dec 2, 2024

jeromelaban approved these changes Dec 2, 2024

View reviewed changes

MartinZikmund force-pushed the dev/mazi/exception-on-navigate branch from 147bb55 to 4aaa91d Compare December 2, 2024 23:07

ajpinedam approved these changes Dec 3, 2024

View reviewed changes

MartinZikmund force-pushed the dev/mazi/exception-on-navigate branch from 4325fbf to b1f25a2 Compare December 3, 2024 10:41

MartinZikmund enabled auto-merge December 3, 2024 12:49

MartinZikmund force-pushed the dev/mazi/exception-on-navigate branch from b1f25a2 to f54f604 Compare December 4, 2024 12:18

MartinZikmund added 5 commits December 8, 2024 17:43

test: When Page throws in constructor, it should propagate to Frame.N…

e62e12a

…avigate

fix: Frame should throw on page exceptions

36fb076

chore: Adjust legacy Frame behavior

ef79f61

chore: Adjust modifiers for WinUI

6b62f7e

chore: Adjust for WinUI

5249fba

MartinZikmund force-pushed the dev/mazi/exception-on-navigate branch from f54f604 to 5249fba Compare December 8, 2024 16:43

MartinZikmund merged commit 49ad730 into master Dec 8, 2024
115 checks passed

MartinZikmund deleted the dev/mazi/exception-on-navigate branch December 8, 2024 21:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Frame` should throw on page exceptions #18983

`Frame` should throw on page exceptions #18983

MartinZikmund commented Dec 2, 2024 •

edited

Loading

unodevops commented Dec 2, 2024

unodevops commented Dec 3, 2024

unodevops commented Dec 3, 2024

unodevops commented Dec 3, 2024

ajpinedam left a comment

unodevops commented Dec 3, 2024

unodevops commented Dec 3, 2024

unodevops commented Dec 3, 2024

unodevops commented Dec 3, 2024

unodevops commented Dec 3, 2024

unodevops commented Dec 4, 2024

unodevops commented Dec 4, 2024

jeromelaban commented Dec 4, 2024

azure-pipelines bot commented Dec 4, 2024

MartinZikmund commented Dec 4, 2024

azure-pipelines bot commented Dec 4, 2024

unodevops commented Dec 4, 2024

unodevops commented Dec 5, 2024

unodevops commented Dec 5, 2024

unodevops commented Dec 8, 2024

unodevops commented Dec 8, 2024

nventive-devops commented Dec 8, 2024

Frame should throw on page exceptions #18983

Frame should throw on page exceptions #18983

Conversation

MartinZikmund commented Dec 2, 2024 • edited Loading

PR Type

What is the current behavior?

What is the new behavior?

PR Checklist

Other information

unodevops commented Dec 2, 2024

unodevops commented Dec 3, 2024

unodevops commented Dec 3, 2024

unodevops commented Dec 3, 2024

ajpinedam left a comment

Choose a reason for hiding this comment

unodevops commented Dec 3, 2024

unodevops commented Dec 3, 2024

unodevops commented Dec 3, 2024

unodevops commented Dec 3, 2024

unodevops commented Dec 3, 2024

unodevops commented Dec 4, 2024

unodevops commented Dec 4, 2024

jeromelaban commented Dec 4, 2024

azure-pipelines bot commented Dec 4, 2024

MartinZikmund commented Dec 4, 2024

azure-pipelines bot commented Dec 4, 2024

unodevops commented Dec 4, 2024

unodevops commented Dec 5, 2024

unodevops commented Dec 5, 2024

unodevops commented Dec 8, 2024

unodevops commented Dec 8, 2024

nventive-devops commented Dec 8, 2024

`Frame` should throw on page exceptions #18983

`Frame` should throw on page exceptions #18983

MartinZikmund commented Dec 2, 2024 •

edited

Loading