-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Adjust a11y documentation #18978
Conversation
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18978/index.html |
- `ItemsControl` doesn't use `AutomationProperties.Name` on its `DataTemplate`'s root. | ||
- There are XAML code generation conflicts between `x:Name` and `AutomationProperties.Name`. | ||
- A child with the same accessible name as its parent is accessibility focusable. | ||
- `Control` doesn't receive focus when accessibility focused. | ||
- `TabIndex` is not supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is supported from a11y point of view?
i.e, if you use TalkBack will it respect TabIndex? I thought TabIndex implementation currently works with focus manager only for tab navigation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I read these only from the implementation perspective, not A11y perspective. Makes sense to keep it there then
@@ -90,13 +90,10 @@ When the value of `WinRTFeatureConfiguration.Accessibility.HighContrast` is chan | |||
|
|||
## Known issues | |||
|
|||
- `Hyperlink` in `TextBlock` is not supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, is this supported from a11y point of view?
I think screen readers are expected to read the text, be able to tell it's hyperlink, and double tapping with a11y focus should open the link. Does it work that way?
@@ -90,13 +90,10 @@ When the value of `WinRTFeatureConfiguration.Accessibility.HighContrast` is chan | |||
|
|||
## Known issues | |||
|
|||
- `Hyperlink` in `TextBlock` is not supported. | |||
- `TextBox` and `PasswordBox` don't use `Header` and `PlaceholderText`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, I think on a11y focus it's expected that screen readers will read the header and placeholder.
Pull request was closed
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):