Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drag&drop): when a child and a parent subscribe to dragging, only fire on the child #18795

Merged
merged 9 commits into from
Dec 9, 2024
Merged

fix(drag&drop): when a child and a parent subscribe to dragging, only fire on the child #18795

merged 9 commits into from
Dec 9, 2024

Conversation

ramezgerges
Copy link
Contributor

GitHub Issue (If applicable): closes #18765

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label Nov 14, 2024
@ramezgerges ramezgerges force-pushed the disable_dragging_in_parent_recognizers branch from 0bcd175 to d0da231 Compare November 14, 2024 23:07
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18795/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18795/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18795/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18795/index.html

@ramezgerges ramezgerges marked this pull request as draft November 15, 2024 15:16
@ramezgerges
Copy link
Contributor Author

This PR is waiting for #18846 to fix some build errors.

@ramezgerges ramezgerges force-pushed the disable_dragging_in_parent_recognizers branch from 7020a97 to 59c4e46 Compare December 3, 2024 11:46
@ramezgerges ramezgerges marked this pull request as ready for review December 3, 2024 11:46
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18795/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18795/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18795/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18795/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18795/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18795/index.html

@ramezgerges ramezgerges force-pushed the disable_dragging_in_parent_recognizers branch from 137d923 to 3f67ea8 Compare December 4, 2024 00:31
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18795/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18795/index.html

@ramezgerges ramezgerges force-pushed the disable_dragging_in_parent_recognizers branch from 3f67ea8 to b7d441e Compare December 4, 2024 11:35
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18795/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18795/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 149310 has failed on Uno.UI - CI.

@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Dec 7, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18795/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18795/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 149656 has failed on Uno.UI - CI.

@jeromelaban jeromelaban merged commit 8359486 into unoplatform:master Dec 9, 2024
112 of 114 checks passed
@ramezgerges ramezgerges deleted the disable_dragging_in_parent_recognizers branch December 9, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinZikmund MartinZikmund MartinZikmund approved these changes

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Desktop] DragStarting called on parent control rather than on child control
4 participants
@ramezgerges @unodevops @MartinZikmund @jeromelaban