Skip to content

Commit

Permalink
chore: Apply code review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
dr1rrb committed Dec 13, 2024
1 parent 6c3cc54 commit 9cfe4ae
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
2 changes: 0 additions & 2 deletions src/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,6 @@

<!-- Required for studio -->
<NoWarn>$(NoWarn);UNO0008</NoWarn>

<NoWarn>$(NoWarn);NU1903</NoWarn>

<!-- On CI, UWP source is generated in a job running on Windows (CRLF EOLs). -->
<!-- When the artifacts are downloaded in a job running on Linux, IDE0055 will complain (expecting LF EOLs) -->
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<!-- There is no need to multi-target this test project -->
<!-- We keep it on the oldest supported TFM -->
<!-- Though we could use UnoTargetFrameworkOverride to choose between NetPrevious and NetCurrent -->
<!-- As of writing this comment, we don't see a need to do that, so we keep it simple -->
<TargetFramework>net9.0</TargetFramework>
<TargetFramework>$(NetCurrent)</TargetFramework>
<IsPackable>false</IsPackable>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
Expand Down
3 changes: 2 additions & 1 deletion src/Uno.UI.Tests/Uno.UI.Unit.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@
</PropertyGroup>
<!--
Uncomment to troubleshoot source generation
-->
<PropertyGroup>
<UnoUISourceGeneratorDebuggerBreak>True</UnoUISourceGeneratorDebuggerBreak>
<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
</PropertyGroup>
-->
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DebugSymbols>true</DebugSymbols>
<DebugType>full</DebugType>
Expand Down
3 changes: 0 additions & 3 deletions src/Uno.UI/Uno.UI.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
</PropertyGroup>

<Import Project="../targetframework-override.props" />
<PropertyGroup>
<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
</PropertyGroup>

<PropertyGroup>
<AssemblyName>Uno.UI</AssemblyName>
Expand Down

0 comments on commit 9cfe4ae

Please sign in to comment.