Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Appxmanifest #692

Merged
merged 2 commits into from
May 22, 2024
Merged

Update Appxmanifest #692

merged 2 commits into from
May 22, 2024

Conversation

dansiegel
Copy link
Contributor

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature

What is the current behavior?

Package.appxmanifest explicitly sets a number of properties that should be set by existing MSBuild properties for Single Project.

What is the new behavior?

Package.appxmanifest has now been simplified with the Single Project MSBuild properties being used to properly set values like the App Name, Title, Description, Version, supported version ranges for Windows and package publisher.

@dansiegel dansiegel enabled auto-merge May 22, 2024 13:51
@dansiegel dansiegel merged commit d9fde28 into main May 22, 2024
52 checks passed
@dansiegel dansiegel deleted the dev/ds/appxmanifest branch May 22, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uno.Sdk (5.2 templates) only allows ApplicationDisplayVersion value 1.0
2 participants