feat(navigationview): Add lightweight styling to navigation view styles #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyeenvy
force-pushed
the
dev/vyng/Lightweight-Styling-NavigationView
branch
3 times, most recently
from
6dc2200
to
912299f
Compare
6 tasks
|
Waiting for PR #1106 to merge before updating this PR. |
|
@silviuo I kept this one for last because I knew it'd be big and then I forgot :) but there will be comments from what I see here. Will look it over now |
silviuo
force-pushed
the
dev/vyng/Lightweight-Styling-NavigationView
branch
from
f3b4c82
to
e0f6d96
Compare
|
I rebased off latest master and refactored resource values to keys |
|
Let's revisit if this PR is still needed after @Xiaoy312 current work with a script |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: https://github.com/unoplatform/uno.themes-private/issues/5
PR Type
What kind of change does this PR introduce?
Description
PR Checklist
Other information
Internal Issue (If applicable):