Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Proximity sample #1028

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

muhmuhhum
Copy link

@muhmuhhum muhmuhhum commented Oct 12, 2023

GitHub Issue (If applicable): closes #1026

PR Type

What kind of change does this PR introduce?

  • Feature Sample Page for Proximity Sensor

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on UWP.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@CLAassistant
Copy link

CLAassistant commented Oct 12, 2023

CLA assistant check
All committers have signed the CLA.

@muhmuhhum
Copy link
Author

muhmuhhum commented Oct 12, 2023

ok so this is a WIP cause i cant test it on my android emulator.
The app just wont start and i cant really find out why.
So i currently start the app in debug with any cpu and the mobile project.
I also changed IsUiAutomationEnabled in the csproj to false
@morning4coffe-dev maybe you could help me out with this.

@muhmuhhum muhmuhhum marked this pull request as ready for review October 16, 2023 07:38
@muhmuhhum muhmuhhum changed the title WIP feat: Add Proximity sample feat: Add Proximity sample Oct 16, 2023
@morning4coffe-dev
Copy link
Member

@muhmuhhum Thanks! Can you please check if it works on Windows (you can add || !HAS_UNO next to the __ANDROID__)? And also sync your branch with current master?

@muhmuhhum
Copy link
Author

@morning4coffe-dev Windows is now tested, added the !HAS_UNO and merged the current master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sample for ProximitySensor
3 participants