New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web-fonts): add downloadLocally options #3723
Draft
onmax
wants to merge
12
commits into
unocss:main
Choose a base branch
from
onmax:onmax/local-fonts
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ca5a114
feat(web-fonts): add downloadLocally options
onmax ae509cb
chore: expose local and remote font modules
userquin 026916a
chore: fix playground build
userquin 1290478
chore: change types and use vite.base in fonts.css
userquin 5904595
chore: include nuxt configuration
userquin efb3c2e
chore: move nuxt config to module
userquin 317a252
chore: add fonts.css to nuxt styles folder
userquin 32a65f5
chore: add font-sans in nuxt app.vue
userquin f52518b
chore: include astro configuration
userquin 912bfe2
chore: export default fonts folder
userquin 901e582
chore: add example in sveltekit example
userquin 1b2dacc
Merge branch 'main' into onmax/local-fonts
userquin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,3 +25,4 @@ interactive/public/shiki | |
.svelte-kit | ||
.eslintcache | ||
vite.config.ts.timestamp-* | ||
unocss-fonts/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,5 +8,6 @@ export default defineBuildConfig({ | |
declaration: true, | ||
externals: [ | ||
'@nuxt/schema', | ||
'pathe', | ||
], | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
import type { Preset } from '@unocss/core' | ||
import type { Nuxt } from '@nuxt/schema' | ||
import { dirname, relative } from 'pathe' | ||
import { defaultFontCssFilename } from '@unocss/preset-web-fonts/local-font' | ||
import type { UnocssNuxtOptions } from './types' | ||
|
||
export function configureWebFontPreset(nuxt: Nuxt, options: UnocssNuxtOptions) { | ||
const webFontPreset = lookupPreset(options, '@unocss/preset-web-fonts') | ||
if (webFontPreset && !!webFontPreset.options?.downloadLocally) { | ||
const downloadDir = `${nuxt.options.dir.public}/unocss-fonts` | ||
webFontPreset.options.downloadLocally = { | ||
downloadDir, | ||
downloadBasePath: nuxt.options.app.baseURL, | ||
} | ||
nuxt.options.css ??= [] | ||
nuxt.options.css.push(`~/${relative(dirname(nuxt.options.dir.public), downloadDir)}/${defaultFontCssFilename}`.replaceAll('\\', '/')) | ||
} | ||
} | ||
|
||
function lookupPreset<P extends Preset<any>>(options: UnocssNuxtOptions, presetName: P['name']) { | ||
const preset: P | undefined = (options.presets || []).flat().find(p => p.name === presetName) as any | ||
return preset | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should use
unshift
?