Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix window is not defined on server rendered apps #401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix window is not defined on server rendered apps #401

wants to merge 1 commit into from

Conversation

brunolemos
Copy link
Member

@brunolemos brunolemos commented May 8, 2024 •
edited

Fix #364
Fix #376

@brunolemos brunolemos self-assigned this May 8, 2024
@koralajoie
Copy link

Any idea when this might be merged?

@akichim21
Copy link

@adeelraza @lucasbesen @ivoIturrieta
Could you merge this?

@mineraux
Copy link

mineraux commented Jun 5, 2024 •
edited

Up on this fix. Is it possible to merge asap please ?
@adeelraza @lucasbesen @ivoIturrieta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasbesen lucasbesen lucasbesen approved these changes

@adeelraza adeelraza Awaiting requested review from adeelraza

@ivoIturrieta ivoIturrieta Awaiting requested review from ivoIturrieta

Assignees

@brunolemos brunolemos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"window is not defined" in NextJS. window is not defined error with Remix 2.0
5 participants
@brunolemos @koralajoie @akichim21 @mineraux @lucasbesen