fix: fire done logic when percent is 1, instead of using the compiler "done" hook #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like in webpack@4, the compiler "done" hook sets progress percentage to 1: https://github.com/webpack/webpack/blob/v4.46.0/lib/ProgressPlugin.js#L291-L293 but in webpack@5, there are some additional cache steps that were added such that it doesn't represent progress 1: https://github.com/webpack/webpack/blob/v5.62.2/lib/ProgressPlugin.js#L569-L574
This seems to be cause of #83