Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fire done logic when percent is 1, instead of using the compiler "done" hook #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

charlessuh
Copy link

It looks like in webpack@4, the compiler "done" hook sets progress percentage to 1: https://github.com/webpack/webpack/blob/v4.46.0/lib/ProgressPlugin.js#L291-L293 but in webpack@5, there are some additional cache steps that were added such that it doesn't represent progress 1: https://github.com/webpack/webpack/blob/v5.62.2/lib/ProgressPlugin.js#L569-L574

This seems to be cause of #83

@hewenguang
Copy link

@pi0

@uki1014
Copy link

uki1014 commented Feb 20, 2022

@pi0 👀

@akijoey
Copy link

akijoey commented Oct 9, 2022

@pi0

1 similar comment
@shuaiqidekaige
Copy link

@pi0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants