fix(proxy): better error when upstream proxy fails #746
+44
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying unjs-h3 with
|
| Latest commit: |
59dc90c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9e059241.unjs-h3.pages.dev |
| Branch Preview URL: | https://fix-proxy-500.unjs-h3.pages.dev |
pi0
reviewed
May 7, 2024
src/utils/proxy.ts
Outdated
| }); | ||
| } catch { | ||
| event.node.res.statusCode = 502; | ||
| event.node.res.statusMessage = "Bad Gateway"; |
There was a problem hiding this comment.
I think only we can assume only proxy had been failed and perhaps we can double check if there is not already set statusCode and message on error (that currently is being ingored)
Additionally, this perhaps can be implemented directly in sendProxy util for consistent behavior
There was a problem hiding this comment.
Moving back to draft until implemented! Good idea 👍🏻
pi0
changed the title
|
Updated to
You mean an existing one in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#722
❓ Type of change
📚 Description
This PR should ensure that
proxyRequests fail gracefully instead of leading to an unhandled node error crashing the server.📝 Checklist