fix(sse): prevent onClosed from firing twice in EventStream #704
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where
onClosed
always fires twice when using Server Sent Events.The following changes were made to fix the issue:
event.node.res.on('close')
hook inonClosed
methodThe following changes were made to related documentation:
eventStream.close()
invocation from./examples/server-sent-events.ts
eventStream.close()
invocation from./docs/1.guide/6.websockets.md
eventStream.close()
invocation from./tests/sse.test.ts
eventStream.close()
doesn't need to be called inonClosed
by default because it is automatically handled whenautoclose
is set to trueπ Linked issue
Fixes #703
β Type of change
π Description
π Checklist