Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sendStream): add support for file streaming #624

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

fix(sendStream): add support for file streaming #624

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b8a88e2
feat(sendStream): add support for file streaming
GalacticHypernova Jan 20, 2024
0d811b5
chore: apply automated fixes
autofix-ci[bot] Jan 20, 2024
7d100e2
Update response.ts
GalacticHypernova Jan 20, 2024
93c1f98
Update response.ts
GalacticHypernova Jan 27, 2024
94200d6
chore: apply automated fixes
autofix-ci[bot] Jan 27, 2024
90339b1
Update response.ts
GalacticHypernova Jan 27, 2024
dededf4
chore: apply automated fixes
autofix-ci[bot] Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/utils/response.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,11 @@
}

export function defaultContentType(event: H3Event, type?: string) {
if (type && !event.node.res.getHeader("content-type")) {
if (
type &&
event.node.res.statusCode !== 304 /* unjs/h3#603 */ &&
!event.node.res.getHeader("content-type")
) {
event.node.res.setHeader("content-type", type);
}
}
Expand All @@ -94,14 +98,14 @@

export function getResponseHeaders(
event: H3Event,
): ReturnType<H3Event["res"]["getHeaders"]> {
): ReturnType<H3Event["node"]["res"]["getHeaders"]> {
return event.node.res.getHeaders();
}

export function getResponseHeader(
event: H3Event,
name: HTTPHeaderName,
): ReturnType<H3Event["res"]["getHeader"]> {
): ReturnType<H3Event["node"]["res"]["getHeader"]> {
return event.node.res.getHeader(name);
}

Expand Down Expand Up @@ -220,7 +224,11 @@
if (!stream || typeof stream !== "object") {
throw new Error("[h3] Invalid stream provided.");
}

// Value is a buffer, like an image byte buffer
if (Buffer.isBuffer(stream)) {
// TODO
event.node.res.end(stream);
}

Check warning on line 231 in src/utils/response.ts

View check run for this annotation

Codecov / codecov/patch

src/utils/response.ts#L229-L231 

Added lines #L229 - L231 were not covered by tests
// Directly expose stream for worker environments (unjs/unenv)
(event.node.res as unknown as { _data: BodyInit })._data = stream as BodyInit;

Expand Down