Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include breaking change message if provided #148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarkMcCulloh
Copy link

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adding a BREAKING CHANGES: trailer, per conventional commits, will now use that message in the "Breaking Changes" section of the changelog.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
    • Not sure where the documentation is supposed to go?

Comment on lines +179 to +180
function groupBy<TItem>(items: TItem[], key: string) {
const groups: Record<string, TItem[]> = {};
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function was returning any for me locally, seemed useful to provide types

@reslear
Copy link

reslear commented Apr 17, 2024

any changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants