-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded to_f64
funciton
#4839
Merged
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
116a32a
Merge branch 'main' of github.com:unicode-org/icu4x
younies e5dc613
Merge branch 'main' of github.com:unicode-org/icu4x
younies ba775dc
Fix the to_f64 function in `IcuRatio`
younies 0bc2520
Merge branch 'main' into dev-fix-to-f64
younies d869427
Remove to_f64
younies 3d330ed
remove unneeded dependency
younies 1221adf
Fix
younies b07a1ab
Merge branch 'dev-fix-to-f64' of github.com:younies/icu4x into dev-fi…
younies 59b0235
Merge branch 'main' of github.com:unicode-org/icu4x into dev-fix-to-f64
younies 3e25ad0
remove unneeded `use`
younies 55487ae
fix
younies 7d09db9
Merge branch 'main' of github.com:unicode-org/icu4x into dev-fix-to-f64
younies 42e3e99
Merge branch 'main' of github.com:unicode-org/icu4x into dev-fix-to-f64
younies 47cf644
Fix extra clone
younies File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is why there should also be a
-> &BigRational
method, this clone is not necessary becauseto_f64
doesn't need ownership. However, given that this is in-crate, you can usetest.result.0.to_f64()