Implement end to end CurrencyFormatter for short and narrow formatting
#4452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
younies
changed the title
CurrencyFormatterCurrencyFormatter for short and narrow formatting
younies
commented
Mar 23, 2024
| let fmt = CurrencyFormatter::try_new(&locale, Default::default()).unwrap(); | ||
| let value = FixedDecimal::try_from("12345.67").unwrap(); | ||
| let value = FixedDecimal::from("12345.67"); | ||
| let value = FixedDecimal::try_from_f64(12345.67, FloatPrecision::Floating).unwrap(); |
There was a problem hiding this comment.
@sffc , why there is no way to create FixedDecimal in tests?
There was a problem hiding this comment.
Your function calls are not correct.
To create from a string, FixedDecimal implements FromStr, which has a method named from_str. You can also call parse() on a string.
To create from a float, you would need to enable the ryu feature (but you should prefer creating from ints or strings).
There was a problem hiding this comment.
Thanks for the illustration, I have used parse
sffc
previously approved these changes
Mar 26, 2024
| let formatted_currency = fmt.format_fixed_decimal(&value, currency_code); | ||
| let mut sink = String::new(); | ||
| formatted_currency.write_to(&mut sink).unwrap(); | ||
| assert_eq!(sink.as_str(), "$12345.67"); |
There was a problem hiding this comment.
Please file an issue about loading grouping separators and using fixeddecimalformatter
Co-authored-by: Shane F. Carr <[email protected]>
sffc
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
CurrencyFormatterto handle 'short' and 'narrow' currency formatting patterns.