fix: personal spaces can be made private without a pro plan

[BlankParticle]

What does this PR do?

Fixes ENG-140
Personal spaces can always be made private regardless of pro plan
Once affected spaces are private again, we don't allow to open them to avoid confusion

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Chore (refactoring code, technical debt, workflow improvements)
• Enhancement (small improvements)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist

Required

• Read Contributing Guide
• Self-reviewed my own code
• Tested my code in a local environment
• Commented on my code in hard-to-understand areas
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the UnInbox Docs if changes were necessary

[BlankParticle]

• fix: personal spaces can be made private without a pro plan #776 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BlankParticle and the rest of your teammates on Graphite

[McPizza0]

@BlankParticle i think we should change this to never allow personal spaces to be public in the first place
will be less confusing for people

[BlankParticle]

@BlankParticle i think we should change this to never allow personal spaces to be public in the first place will be less confusing for people

there might be use cases for people to have open personal spaces, also we need to alllow people who have accidently made their spaces open

[McPizza0]

there might be use cases for people to have open personal spaces, also we need to alllow people who have accidently made their spaces open

maybe only a tiny few usecases
most of the time they can just add people to the space
If someone accidentally made it open; we can account for that.

if personal space is true, allow it to be set to private, but dont allow to be set to open (open is disabled)

[BlankParticle]

ok, will do that

[BlankParticle]

@McPizza0, have done as you asked, also added the missing backend checks

[BlankParticle]

Merge activity

• Sep 11, 7:59 AM EDT: @BlankParticle started a stack merge that includes this pull request via Graphite.
• Sep 11, 8:00 AM EDT: Graphite rebased this pull request as part of a merge.
• Sep 11, 8:01 AM EDT: @BlankParticle merged this pull request with Graphite.