Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync methods for IEfCoreScope #17948

Closed
wants to merge 1 commit into from

Conversation

PeterKvayt
Copy link
Contributor

Prerequisites

There is an existing discussion

Description

See in existing discussion

Copy link

github-actions bot commented Jan 12, 2025

Hi there @PeterKvayt, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@emmagarland
Copy link
Contributor

Hi @PeterKvayt

Thanks for your PR to add Sync methods for IEfCoreScope.

One of the Core Collaborators team will review this as soon as possible,

Best wishes

Emma

@mikecp mikecp self-assigned this Jan 22, 2025
@nul800sebastiaan
Copy link
Member

Hey there @PeterKvayt and thanks for the PR!

We encourage people to start a discussion to get feedback before they start working on a PR. We don't want you to do a lot of work and waste your time.

In this case, luckily it wasn't a lot of work, but I am going to close your PR.
We're working on making as much async as we can and are not adding any new sync methods. Your workaround as noted in the discussion is a good one, and we encourage you to use that instead.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants