Remove explicit ExamineIndexRebuilder
service registration and make class internal
#17523
+17
−92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Deploy uses
Suspendable.ExamineEvents.ResumeIndexers(...)
to resume suspended indexing after deployments, but this method still required the obsoletedExamineIndexRebuilder
type. I've updated this overload to accept theIIndexRebuilder
instead and also obsoleted the unusedSuspendable.PageCacheRefresher
(if used, it would callContentCacheRefresher.RefreshAll()
that throws aNotSupportedException
, so I've also made it a no-op call).As per obsoletion messages and comments, I've removed the explicit
ExamineIndexRebuilder
service registration and make the class internal (so theIIndexRebuilder
interface needs to be used/injected instead).Testing can be done by simply checking whether all tests still succeed and optionally manually rebuilding the indexes from the backoffice and testing the search functionality.