Feature: Make discard changes work for modals #17515
Draft
+317
−286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslyngsoe
changed the title
…istration # Conflicts: # src/Umbraco.Web.UI.Client/src/packages/core/modal/context/modal.context.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE, REQUIRES NEW VERSION OF UUI TO BE IMPLEMENTED FIRST!
A version of UUI with this PR as part of it:
umbraco/Umbraco.UI#953
fixes #17529
Move route registration logic to collection context — despite still begin initialized at the local collection-view.
And corrects modal route logic, so its possible for a modal to be canceled and jet not submitted.
Also corrects Router-slot to make the 'willChangeState' event include url when it the browser that navigates.
Prerequisites
If there's an existing issue for this PR then this fixes
Description