Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated navigator.platform with navigator.userAgent for platform detection. #17373

Open
wants to merge 1 commit into
base: v13/contrib
Choose a base branch
from

Conversation

manutdkid77
Copy link
Contributor

This fixes #13156

Description

Browser OS information uses the deprecated method navigator.platform. So I replaced it with navigator.userAgent, exactly the same as how it is used in umbraco v15.

Note: Though the issue is reported for v10 and v11. It is present in v13 LTS as well.

How to test

  1. Log into the Umbraco Backoffice.
  2. Click on the Help icon in the top right of the screen.
  3. View the System Information from the sidebar that appears.
  4. Check the Browser (user agent) string

image

Copy link

github-actions bot commented Oct 27, 2024

Hi there @manutdkid77, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@emmagarland
Copy link
Contributor

Hi @manutdkid77!

Thanks for this contribution! One of the core Collabs team will take a look at it soon 🔜

Best wishes

Emma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants