Fix file descriptor leak in service on quit(). #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
LaurentOngaro
pushed a commit
to LaurentOngaro/F_undetected-chromedriver
that referenced
this pull request
Apr 5, 2024
ilike2burnthing
added a commit
to FlareSolverr/FlareSolverr
that referenced
this pull request
Apr 9, 2024
|
Is this still working for you with Chrome v124? I implemented this for FlareSolverr, was working fine with v123, but now not with v124 - FlareSolverr/FlareSolverr#1161 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the chromedriver service is closed gracefully in
quit(), allowing the service to free any allocated file descriptors. If the service is simply killed, the file descriptors are not properly freed, eventually resulting in the "Too many open files" error in Linux.Also see:
#1123