3.5.2 - Minor changes and fixes #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed search paths for Chrome Canary and Chrome Beta from find_chrome_executable()
since chromedriver is always behind schedule so that means a driver for newer versions than current main could not be found and raises Exception.
* Changed/Fixed wrong binary version caused by patcher.
Due to multi-threading people and a mistake fromy my side,
the driver binary currently on disk was always used instead of getting new ones. even if you did not use multithreading.
so even outdated binaries where kept!
for multithreading people, it now only keeps the most recent binary and throws away others.
for normal people, you will get the binary you deserve ;)
* Added more descriptive exceptions when Chrome binary could not be found origin
no connection could be made to Chrome.
* some stuff i forgot
|
Even if i specify the driver_executable_path (a downloaded chromedriver) if it's an older version now it throws away and download a new one? Or now i dont need more download it before, just let the UC download itself. Im using multithreaded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed search paths for Chrome Canary and Chrome Beta from find_chrome_executable() since chromedriver is always behind schedule so that means a driver for newer versions than current main could not be found and raises Exception.
Changed/Fixed wrong binary version caused by patcher. Due to multi-threading people and a mistake fromy my side, the driver binary currently on disk was always used instead of getting new ones. even if you did not use multithreading. so even outdated binaries where kept, hence many people got the dreaded "wrong version" error.
Added more descriptive exceptions when Chrome binary could not be found origin no connection could be made to Chrome.
some stuff i forgot, like bumping version on pypa so it installs correct version :)