-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py3: add new helper: get_replacements_list #2242
base: master
Are you sure you want to change the base?
Conversation
0596fad
to
2d05477
Compare
Ideally, we should separate this into
|
Merged verison of the two regex patterns according to GPT. Untested.
|
@ultrabug Review plz. |
I didn't add this for I don't need this for |
An alternative to PRs listed below.
I copied
thresholds
code. Minimal test. Allow users to be more specific.Get placeholders_list first so we can target existing placeholders rather than all placeholders.
I don't know if this PR is the optimal solution, just an alternative.
Code untested on this player.. I tested on
nvidia_smi
. Sorry if you ran into issues.This is just an idea / experiment.
Please test this.
Solves #2234 (comment).
Closes #2234.
Closes #2237.