-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file_status: patch to fix plural wording #1389
Conversation
@cyrinux Fix Travis. EDIT: Lmao. New version went out.... It's going to be messy depreciating this properly. Idk. Give up, maybe.... or we can still deprecate it. ;-) |
Hey @lasers sorry, was too slow, i try to fix this. |
@lasers, is it good for you as this? |
@cyrinux Yes. Very nice. Add this too and we should be done. diff --git a/py3status/modules/file_status.py b/py3status/modules/file_status.py
index 5d15b09b..a5699513 100644
--- a/py3status/modules/file_status.py
+++ b/py3status/modules/file_status.py
@@ -149,6 +149,7 @@ class Py3status:
if self.thresholds:
self.py3.threshold_get_color(count_path, 'path')
+ self.py3.threshold_get_color(count_path, 'paths')
return {
'cached_until': self.py3.time_in(self.cache_timeout), |
Hi :) Is it well for recover color from old format? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, coloring for old 3.11
format. We 3.12
. ;-) Ty.
py3status/modules/file_status.py
Outdated
self.py3.threshold_get_color(count_path, 'paths') | ||
|
||
return { | ||
'cached_until': | ||
self.py3.time_in(self.cache_timeout), | ||
'full_text': self.py3.safe_format( | ||
self.format, { | ||
'paths': count_path, | ||
'path': count_path, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cyrinux Can you add paths: count_path # deprecation
here? This trips because it's a list. Deprecation replace_placeholder
works on {paths}
but not \?if=paths
. Ty. Sorry. Xoxo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Xoxo ^^
6963a51
to
0cf4bf8
Compare
0cf4bf8
to
c8098c3
Compare
Are you trying to remove plural wording or to add one? I see a mix of both in the resulting file, I'm confused |
Both. |
c0fd701
to
57a1aa7
Compare
0c5742e
to
0482a40
Compare
@ultrabug Ping. |
K @lasers following our discussion, I merge |
see #1369 (comment)