-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file_status: allow several paths, new format #1369
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
3054842
allow glob (wildcard *) in path params
cyrinux 1909b9e
remove post_config_hook because expanduser and glob must be done for
cyrinux bced76b
expand user at post_config_hook
cyrinux eec5c31
python2 compat
cyrinux 1b4c212
add fullpath and basename in format_path
cyrinux d1e5567
str basestring @lasers fix
cyrinux e7fd61e
test list instead of string, remove try/except
cyrinux 5933dde
lasers recommandations, propose new format instead of legacy by default
cyrinux 4484da1
try to do light placeholders stuff
cyrinux d76b49d
deprecate icon_available, icon_unavailable
cyrinux ef9825e
cleanup, follow @lasers professor advises
cyrinux 08b7481
implement threshold_get_color
cyrinux 24a5160
@lasers review
cyrinux c96a435
shorter way to handle no path set
cyrinux 8fa66b0
@lasers refacto
cyrinux e15eedc
professor nitpick :P
cyrinux fb4c723
support {icon}
cyrinux 67e26e6
@lasers sweep
cyrinux b84fda9
its better with a fallback icon
cyrinux fb82b53
Merge branch 'master' into file_status-allow-glob
cyrinux 0bfe17a
Merge branch 'master' into file_status-allow-glob
cyrinux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember it correctly, the family mentioned something about storing icons properly, eg
(default '\?color=paths [\?if=paths \u25cf|\u25a0]')
so I assume we should change it everywhere to be similar toSAMPLE OUTPUT
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the goal? For readability? Compliance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember all the details. I think readability so some things are not rendered as blocks or to avoid cause minor confusion. It may or may not had to do more with control characters. ~~EDIT: Maybe wait for the family.~~~
versus more explicit...