mpris module: hide all non can_play players (#2267)

ultrabug · Dec 3, 2024 · 3d2a96e · 3d2a96e
1 parent 5a74d67
commit 3d2a96e
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/py3status/modules/mpris.py b/py3status/modules/mpris.py
@@ -23,9 +23,6 @@
     icon_previous: specify icon for previous button (default u'\u25c3')
     icon_stop: specify icon for stop button (default u'\u25a1')
     max_width: maximum status length (default None)
-    player_hide_non_canplay: For hiding players which doesn't close mpris interface after media closing
-        (for example chromium based browsers)
-        (default [])
     player_priority: priority of the players.
         Keep in mind that the state has a higher priority than
         player_priority. So when player_priority is "[mpd, bomi]" and mpd is
@@ -152,7 +149,6 @@ def __init__(
         self._player_shortname = name_from_id
         self._dPlayer = dPlayer(dbus_interface_info={"dbus_uri": player_id})
         self._full_name = f"{self._identity} {self._identity_index}"
-        self._hide_non_canplay = self._player_shortname in self.parent.player_hide_non_canplay
 
         self._placeholders = {
             "player": self._identity,
@@ -348,7 +344,7 @@ def data(self):
 
     @property
     def hide(self):
-        return self._hide_non_canplay and not self._can.get("CanPlay")
+        return not self._can.get("CanPlay")
 
     @property
     def id(self):
@@ -382,12 +378,21 @@ class Py3status:
     icon_previous = "\u25c3"
     icon_stop = "\u25a1"
     max_width = None
-    player_hide_non_canplay = []
     player_priority = []
     state_pause = "\u25eb"
     state_play = "\u25b7"
     state_stop = "\u25a1"
 
+    class Meta:
+        deprecated = {
+            'remove': [
+                {
+                    'param': 'player_hide_non_canplay',
+                    'msg': 'obsolete because we now hide all non canplay players',
+                },
+            ],
+        }
+
     def post_config_hook(self):
         self._name_owner_change_match = None
         self._kill = False
@@ -485,7 +490,7 @@ def post_config_hook(self):
                 self._format_contains_control_buttons = True
                 self._used_can_properties.append(value["clickable"])
 
-        if len(self.player_hide_non_canplay) and "CanPlay" not in self._used_can_properties:
+        if "CanPlay" not in self._used_can_properties:
             self._used_can_properties.append("CanPlay")
 
         self._format_contains_time = self.py3.format_contains(self.format, "time")