Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intersection api for Set #51

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Intersection api for Set #51

merged 3 commits into from
Oct 28, 2024

Conversation

RoDmitry
Copy link
Contributor

@RoDmitry RoDmitry commented Sep 19, 2024

(copy from HashSet)

@udoprog udoprog added the enhancement New feature or request label Sep 19, 2024
@RoDmitry
Copy link
Contributor Author

Any links that explain why ::core is inconsistent?

@udoprog
Copy link
Owner

udoprog commented Oct 28, 2024

Any links that explain why ::core is inconsistent?

It was an inconsistent across my own projects and doesn't contribute to how the code is compiled. It can sometimes be useful inside of macros if there's ambiguity.

Also, thanks for the impl!

The build was disabled due to Github policy so I was never pinged when it was completed. Since I needed to push again to re-trigger the build I decided to do a bit of cleanup at the same time.

@udoprog udoprog merged commit 99b44bb into udoprog:main Oct 28, 2024
5 checks passed
@udoprog
Copy link
Owner

udoprog commented Oct 28, 2024

There are some more HashSet APIs that could be ported if that's something you want to take a stab at. I added the From<[T; N]> impl for Set<T> here which allows doc tests to be a bit cleaner. Otherwise I'll be baking a new release in a day or two.

The primary issue for "missing APIs" is #11.

@RoDmitry
Copy link
Contributor Author

RoDmitry commented Oct 28, 2024

Not important, but I personally prefer ::core and ::std so it compiles a bit faster, like milliseconds faster, maybe which nobody would even notice 🙂

@RoDmitry RoDmitry deleted the intersection branch October 28, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants