Skip to content
This repository has been archived by the owner on Aug 7, 2022. It is now read-only.

fix: KV Namespace list method accepts an object #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: KV Namespace list method accepts an object #32

wants to merge 3 commits into from

Conversation

13rac1
Copy link
Contributor

@13rac1 13rac1 commented Jun 4, 2021

The KV.list() method signature according to the docs is:

NAMESPACE.list({prefix?: string, limit?: number, cursor?: string})

This solution seems correct to resolve #27 but I'm not 100% about it. Open to better ideas??? @adamjakab @marcelduin

@13rac1 13rac1 added the bug Something isn't working label Jun 4, 2021
richardkalehoff
richardkalehoff approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@richardkalehoff richardkalehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor suggestions, but this looks good to me 👍🏻

test/helloworker.test.ts Outdated Show resolved Hide resolved
test/helloworker.test.ts Outdated Show resolved Hide resolved
13rac1 and others added 2 commits June 9, 2021 11:32
@13rac1 @richardkalehoff
nit: Reduce test param lookup
d28ad14 
Co-authored-by: Richard Kalehoff <[email protected]>
@13rac1 @richardkalehoff
nit: Remove unnecessary undefines
10fb87f 
Co-authored-by: Richard Kalehoff <[email protected]>
@13rac1 13rac1 self-assigned this Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richardkalehoff richardkalehoff richardkalehoff approved these changes

@kyrstenkelly kyrstenkelly Awaiting requested review from kyrstenkelly

Assignees

@13rac1 13rac1

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KV Namespace list method signature confusion
2 participants
@13rac1 @richardkalehoff