Michaelborkowski/benchmarks #1843
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @michaelborkowski ! any idea why the tests are failing? |
|
I committed to my branch with a syntax error and tried to --amend the commit. But that looks like it broke the tests somehow. Let's reject/delete this PR and I'll try to create a new one where the appveyor tests pass |
…-progsys/liquidhaskell into michaelborkowski/benchmarks
|
I made another commit so that the tests would run again. The appveyor ones pass. Are the ci/circleci supposed to pass? They fail with the error |
|
@michaelborkowski, @ranjitjhala, would you like to merge this PR or should we close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains syntactic corrections and proof combinator modernization in order to get all of the POPL 18 PLE benchmarks working with the current version of Liquid Haskell.
Ackermann.hs is restored to the test suite in each of its versions:
benchmarks/popl18/nople/neg/Ackermann.hs
benchmarks/popl18/nople/pos/Ackermann.hs
benchmarks/popl18/ple/pos/Ackermann.hs
OverviewListInfix.hs is restored to the test suite in each of its versions:
benchmarks/popl18/nople/pos/OverviewListInfix.hs
benchmarks/popl18/ple/pos/OverviewListInfix.hs
(There are still some nople tests that are ignored.)