-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add print/plot S3 methods for VennDiagram #28
Conversation
NEWS
Outdated
@@ -1,3 +1,8 @@ | |||
VennDiagram 1.7.4 2023-02-28 (Stefan Eng) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as previous version number.
DESCRIPTION
Outdated
@@ -1,5 +1,5 @@ | |||
Package: VennDiagram | |||
Version: 1.7.4 | |||
Version: 1.7.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 1.8.0
as this is technically new functionality?
Very cool quality of life improvement. Could we add some unit tests for the different cases in the S3 function? |
I'm not quite sure how to test this. Any suggestions? |
Given the current end-to-end test cases, do the changes you made here affect them as written? In other words, if this code was incorrect, would it make the existing test cases fail? |
All the old tests still work. No, it would not make the tests fail since there old tests don't look at class at all and there is no print or plot method called at all. |
Right. It might just be good to have some code that explicitly calls the S3 methods you defined here. Also, maybe a test case that asserts |
Description
Implement print/plot S3 methods for VennDiagram class.
Closes #26
Checklist
.png
, .jpeg
),.pdf
,.RData
,.xlsx
,.doc
,.ppt
, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.main
branch protection rule following the github standards before opening this pull request.CHANGELOG.md
under the next release version or unreleased, and updated the date.Example
No
grid.draw
call required.