fixing issue unresolve bug and adding concept of scanIssue/decreased … #873
Conversation
…amount of intial data on issue load
|
Whenever I try to run UDOIT on the cidilabs:fixUnresolveBug branch, I, for some reason, am not able access any of the issues and the issue window loading screen just loops infinitely. PHP just returns a 404 error.
|
|
@taheralfayad I'll take a look, thanks for pointing that out. |
| let showExample = false | ||
| if (!this.props.t(`rule.example.${activeIssue.scanRuleId}`).includes('rule.example')) { | ||
| showExample = true | ||
| } | ||
|
|
||
| let code = this.prepareCode(activeIssue) | ||
| if (!this.state.issueDetailsPending) { | ||
| UfixitForm = ufixitService.returnIssueForm(activeIssue) |
There was a problem hiding this comment.
I cannot find ufixitService anywhere in the React files, only on this line. Returns an error:
Uncaught (in promise) ReferenceError: ufixitService is not defined
at a.value (app.js:252:268294)
at Pa (app.js:377:69887)
at Na (app.js:377:69682)
at gs (app.js:377:105481)
at cl (app.js:377:96728)
at sl (app.js:377:96653)
at Zs (app.js:377:93683)
at app.js:377:45325
at t.unstable_runWithPriority (app.js:11:3844)
at Fi (app.js:377:45034)
There was a problem hiding this comment.
Can confirm that like @taheralfayad, I also get the infinite loop upon clicking on any issue, as well as a 404 error in the logs.
|
Hey @atarisafari, it's been a while since this PR has had any updates but have you by any chance been able to test the issue @taheralfayad and I were having, regarding the immediate infinite loading screen? I'm unable to test the branch as is. Thank you! |
|
Hey @atarisafari, thank you for working on this issue, though I'm not able to test the fix since @taheralfayad and I get an infinite loading screen and 404 error when we try to load issues on UFIXIT. I'll close this and likely make another branch/PR in the future to look into the issue closer. Please let me know if you'd like to troubleshoot the roadblock on your branch! I'd be happy to assist and reopen the PR if we can get past that. |
…amount of intial data on issue load
Fixes: #867
Adds concept of loading less issue data on initial app load, but scanning for further issue data when the issue is opened in the modal.