Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial scoring for pick-all questions #2020

Open
wants to merge 5 commits into
base: dev/33-serpierite
Choose a base branch
from

Conversation

jpeterson976
Copy link
Contributor

Resolves #545

MC questions that are pick-all should now calculate their scores based on how many correct/incorrect options were chosen, instead of being all-or-nothing.

@FrenjaminBanklin
Copy link
Contributor

While I see this as a clear improvement, it does change the way assessments are graded which could have unintended consequences on grade review.

For example if a student took an assessment before this update and got no credit for a 'select all that apply' question, then go back to review that assessment score after this update goes into effect, do they still see the 0% for that question, or does the partial credit calculation say they should have received credit?
I also assume this means if a student in the above situation goes to an assessment where before they lost points on select-all questions and answers those questions the exact same way, they'd end up getting more points than their previous attempts.

I can also imagine a scenario where authors want a multi-select question that specifically grants a 0% if the student does not select all possible correct answers. Is that readily possible? If not, MC questions would need some kind of a toggle which defaults to the old behavior so everything stays backwards compatible.

@jpeterson976
Copy link
Contributor Author

It looks like previous attempt scores are correctly showing 0% for a partially incorrect question, if the assessment was taken without partial scores.

That's a good point about allowing authors to choose whether they want partial scoring or not though, I'll work on adding a toggle for it.

@FrenjaminBanklin FrenjaminBanklin changed the base branch from dev/28-jadeite to dev/29-sodalite August 26, 2022 20:11
… if the question type is 'multiple choice' and the response type is 'pick all'.
Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find any gotchas, and everything looks good and seems to be working well. Approved based on that.

I added a last-minute bit of logic to only show the 'partial credit' toggle when the question is a MC type and the 'choose all correct answers' option is chosen since it didn't make sense to make a whole new issue. Little awkward approving my own work, so another set of eyes on it just to make sure I didn't miss anything would be nice.

@FrenjaminBanklin FrenjaminBanklin changed the base branch from dev/29-sodalite to dev/30-howlite February 14, 2023 20:10
@FrenjaminBanklin FrenjaminBanklin dismissed their stale review February 14, 2023 20:10

The base branch was changed.

RachelDau
RachelDau previously approved these changes Feb 15, 2023
Copy link
Contributor

@RachelDau RachelDau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checkout this out and it all looks good on all browsers. Button to toggle partial scoring only appears when it is suppost to and works well. Scoring looks good and the code is clean.

@FrenjaminBanklin FrenjaminBanklin changed the base branch from dev/30-howlite to dev/31-taconite March 20, 2023 17:21
@FrenjaminBanklin FrenjaminBanklin dismissed RachelDau’s stale review March 20, 2023 17:21

The base branch was changed.

@RachelDau RachelDau self-requested a review March 28, 2023 13:15
RachelDau
RachelDau previously approved these changes Mar 28, 2023
Copy link
Contributor

@RachelDau RachelDau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…icts and fixed test breakage. Fixed sudden stylelint violations.
@RachelDau RachelDau changed the base branch from dev/31-taconite to dev/33-serpierite September 28, 2023 13:26
@RachelDau
Copy link
Contributor

I spent some time creating different scenarios in assessments and manually checking the math of the score and it looks good. I didn't find any issues with the scoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants