Fixes/improves expired preview log handling #1585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One overlooked change to the API error state improvements is the way expired preview logs are handled; they no longer tripped the Preview Expired view rendering because the API was returning a
204
instead of an error code. This small PR adds a newexpired()
static method to the MateriaMsg
class, which returns a410
response (Gone) instead of a204
. Note that the associated react query hasretry: false
applied to reduce the delay between error receipt and the Expired Preview view being rendered.