-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deps update to minor versions and fix did-key upstream dep #48
Conversation
badba91
to
db89215
Compare
Fixes #49 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zeeshanlakhani thanks for this change. Can you share the rationale for restricting the version ranges this much?
At a glance, it seems unnecessary to me; as a library, we should be liberal with version ranges so that applications can restrict versions as it suits their use case.
Oh, I don't think we're being too restrictive. We're essentially letting patch versions float, but you don't want feature/major versions to float because they may contain breaking changes, and sometimes minor versions can cause issues as well. With this at least, if dependabot gets a new minor, we can run it through CI. |
I think I agree @zeeshanlakhani but in semantic versioning, |
@cdata my bad, I was texting over mobile at the doctor's office. Yes, this lets patches float, where as some libs, e.g. tokio/tracing/etc, even hardline on the patch. |
db89215
to
36516be
Compare
FWIW - Rust ecosystem has whole lot of SemVer exemption footguns to be aware of - Raised #51 to perhaps clarify policy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. Thanks for the insights re: semver in cargo.
As a general rule, we should stay liberal with regards to version ranges. If there are specific dependencies that are known to be "bad" semver citizens, we can deal with those on a case-by-case basis. Similarly, if there are dependencies that are highly sensitive (like crypto primitives), let's consider those candidates for more cautious version range strategies. In all special cases, we should document the rationale with comments.
Thanks for making this update!
Let our deps float on patch versions and fix did-key upstream dep issues.