postmarketos: use pretty_name for display labels #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3324 +/- ##
==========================================
- Coverage 84.06% 83.99% -0.08%
==========================================
Files 32 32
Lines 1086 1081 -5
==========================================
- Hits 913 908 -5
Misses 173 173 ☔ View full report in Codecov by Sentry. |
|
Bump? |
|
Review please :) |
Flohack74
previously approved these changes
Mar 10, 2024
|
Ugh one of the security issues reported by CI is caused by progressive-downloader dependencies but that was pinned to that version with #3243 |
|
FTR updated the dependencies of progressive-downloader for the 1.x version here: https://gitlab.com/z3ntu/progressive-downloader-node/-/commits/1.x |
Flohack74
previously approved these changes
May 9, 2024
BPO now has pretty_name fields for interfaces, releases (and devices). Use them and remove the hardcoded UI name mappings.
Flohack74
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BPO now has pretty_name fields for interfaces, releases (and devices). Use them and remove the hardcoded UI name mappings.