Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session store to track executed actions #2832

Merged
merged 2 commits into from
Nov 28, 2022
Merged

session store to track executed actions #2832

merged 2 commits into from
Nov 28, 2022

Conversation

NeoTheThird
Copy link
Member

WIP approach for #2532

@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Base: 83.61% // Head: 83.84% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (5ab18b4) compared to base (919a81e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2832      +/-   ##
==========================================
+ Coverage   83.61%   83.84%   +0.23%     
==========================================
  Files          31       32       +1     
  Lines        1050     1065      +15     
==========================================
+ Hits          878      893      +15     
  Misses        172      172              
Impacted Files Coverage Δ
src/lib/reporter.js 100.00% <ø> (ø)
src/core/core.js 72.14% <100.00%> (+0.61%) ⬆️
src/core/helpers/session.js 100.00% <100.00%> (ø)
src/core/plugins/index.js 100.00% <100.00%> (ø)
src/lib/window.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@NeoTheThird
Copy link
Member Author

From https://ubports.open-cuts.org/run/6362a1c189f6500ec77c3750:

image

Looks OK! I think we could consider this unblocked and enter review, so this branch does not fall too far behind.

@NeoTheThird NeoTheThird marked this pull request as ready for review November 2, 2022 17:16
@NeoTheThird NeoTheThird changed the title [WIP] session store to track executed actions session store to track executed actions Nov 2, 2022
src/lib/window.js Outdated Show resolved Hide resolved
@NeoTheThird NeoTheThird merged commit 1756231 into master Nov 28, 2022
@NeoTheThird NeoTheThird deleted the session branch November 28, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants