Skip to content
This repository has been archived by the owner on Jan 22, 2022. It is now read-only.

Downloads UX Changes #415

Merged
merged 4 commits into from
Feb 3, 2021
Merged

Conversation

kugiigi
Copy link
Contributor

@kugiigi kugiigi commented Dec 3, 2020

Originally from #336

  • Fixes Annoying downloader #193
  • Implemented recent downloads dialog in bot the browser and webapp. This is displayed when a new download started instead of the downloads page.
  • A downloads button is added in the navigation bar which wiggles and turns blue when a download completes. In webapps without the title bar, the recent downloads dialog is displayed instead
  • Only display the file names in the Downloads page instead of full path.
  • Added info such as file size and download speed in the Downloads page
  • Added actions such as copy download link and remove from history

@kugiigi kugiigi force-pushed the xenial_-_downloadsux branch from ddebb19 to 4bade90 Compare December 17, 2020 18:48
Copy link
Member

@UniversalSuperBox UniversalSuperBox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR appears to conflict on DownloadDelegate.qml... Could you rebase it and resolve that conflict? At the moment it isn't testable due to the Oxide removal...

@kugiigi
Copy link
Contributor Author

kugiigi commented Jan 31, 2021

@balcy Is your commit already what Dalton requested? Do I still need to do something here?

@balcy
Copy link
Collaborator

balcy commented Jan 31, 2021

yes it was the merge conflict

Copy link
Member

@UniversalSuperBox UniversalSuperBox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work well on tablet and mobile usecases, but I've found a few issues.

src/app/DownloadsPage.qml Show resolved Hide resolved
@@ -0,0 +1,164 @@
/*
* Copyright 2015-2016 Canonical Ltd.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files that you're creating should at least have a current copyright date, either for yourself or for the UBports Foundation if you wish to assign your copyright to us.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated it to UBports and also to 2021

src/app/SimpleDownloadDelegate.qml Show resolved Hide resolved
@UniversalSuperBox UniversalSuperBox merged commit f6f636e into ubports:xenial Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annoying downloader
3 participants