-
Notifications
You must be signed in to change notification settings - Fork 35
Downloads UX Changes #415
Downloads UX Changes #415
Conversation
ddebb19
to
4bade90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR appears to conflict on DownloadDelegate.qml... Could you rebase it and resolve that conflict? At the moment it isn't testable due to the Oxide removal...
@balcy Is your commit already what Dalton requested? Do I still need to do something here? |
yes it was the merge conflict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work well on tablet and mobile usecases, but I've found a few issues.
src/app/SimpleDownloadDelegate.qml
Outdated
@@ -0,0 +1,164 @@ | |||
/* | |||
* Copyright 2015-2016 Canonical Ltd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files that you're creating should at least have a current copyright date, either for yourself or for the UBports Foundation if you wish to assign your copyright to us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated it to UBports and also to 2021
Updated copyright text and restored UrlUtils
Originally from #336