Skip to content
This repository has been archived by the owner on Jan 22, 2022. It is now read-only.

adapt ChromeStateTracker / ScrollTracker for QtWebEngine #333

Draft
wants to merge 6 commits into
base: xenial
Choose a base branch
from

Conversation

balcy
Copy link
Collaborator

@balcy balcy commented Jul 9, 2020

fixes #165

@balcy balcy marked this pull request as draft July 11, 2020 07:17
@dobey
Copy link
Member

dobey commented Oct 16, 2020

What's the status on this?

@balcy
Copy link
Collaborator Author

balcy commented Oct 17, 2020

that's still draft let's wait with it a bit (at least not ready for OTA14)
It can happen that the menu keeps showing/hiding at certain scroll positions.

@kugiigi
Copy link
Contributor

kugiigi commented May 25, 2021

Perhaps we can use a similar approach as this?
https://gitlab.com/mateosalta/qtwebbrowser_click/-/blob/dev/src/qml/PageView.qml

It's not tracking scrolling per se though but it works pretty well in my experience.

@mateosalta
Copy link
Contributor

Perhaps we can use a similar approach as this?
https://gitlab.com/mateosalta/qtwebbrowser_click/-/blob/dev/src/qml/PageView.qml

It's not tracking scrolling per se though but it works pretty well in my experience.

only problem i saw with that one is the page extends off the screen until you scroll

@kugiigi
Copy link
Contributor

kugiigi commented May 28, 2021

What are the worst case with that issue? Like when a page doesn't scroll vertically and takes up the whole viewport? I think in most cases, it'll be fine since you naturally scroll anyway to see the bottom part.

…ection.enabled is not available in QtQuick 2.4."

- only trigger scrolledUp / scrolledDown while the webview is not loading
@balcy balcy marked this pull request as ready for review June 13, 2021 12:56
@balcy
Copy link
Collaborator Author

balcy commented Jun 13, 2021

ok we might give it a try, I'm still not sure if it usable like that, any improvements / suggestions welcome.
We really could mimic how it is done in "WebEngineDemo", it is quite good to use.

Another question: should we make it an option to automatically hide the Chrome when scrolling down, or activate it for all users ?
It used to be like that for the old webbrowser-app (without an option).

@balcy balcy marked this pull request as draft June 24, 2021 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll up navigation bar
4 participants