Skip to content
This repository has been archived by the owner on Jan 22, 2022. It is now read-only.

Commit

Permalink
Set a default for offTheRecord in MorphWebContext (#376)
Browse files Browse the repository at this point in the history
QtWebEngine 5.13 changed the default value of offTheRecord from false to
"is the given storage path empty?" This means that apps will dump all
cookies and site data on exit by default.

If someone is using the MorphWebContext as part of their app, they
expect the old behavior with offTheRecord = false. So we'll just set
that.

We have vendor-patched QtWebEngine to maintain the old behavior there.
I feel that this is still worth having to make future API breaks
explicit.

#347
qt/qtwebengine@6e28e76
  • Loading branch information
UniversalSuperBox authored Nov 23, 2020
1 parent f8b54da commit 2049e58
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/Morph/Web/MorphWebContext.qml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ WebEngineProfile {
property alias incognito: oxideContext.offTheRecord
readonly property string defaultUserAgent: __ua.defaultUA

offTheRecord: false

dataPath: dataLocation

cachePath: cacheLocation
Expand Down

0 comments on commit 2049e58

Please sign in to comment.