-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github E2E Tests #1614
Merged
Merged
Github E2E Tests #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velioglu
force-pushed
the
velioglu/gr_e2e_test
branch
2 times, most recently
from
May 17, 2024 06:12
045a113
to
de23ae9
Compare
enescakir
reviewed
May 17, 2024
enescakir
reviewed
May 17, 2024
enescakir
reviewed
May 17, 2024
enescakir
reviewed
May 17, 2024
enescakir
reviewed
May 17, 2024
enescakir
reviewed
May 17, 2024
enescakir
reviewed
May 17, 2024
enescakir
reviewed
May 17, 2024
velioglu
force-pushed
the
velioglu/gr_e2e_test
branch
4 times, most recently
from
May 17, 2024 23:07
83bd32f
to
c6ead40
Compare
enescakir
reviewed
May 20, 2024
velioglu
force-pushed
the
velioglu/gr_e2e_test
branch
5 times, most recently
from
May 21, 2024 07:45
a6f014b
to
8063307
Compare
enescakir
reviewed
May 21, 2024
enescakir
reviewed
May 21, 2024
enescakir
reviewed
May 21, 2024
enescakir
reviewed
May 21, 2024
enescakir
reviewed
May 21, 2024
enescakir
reviewed
May 21, 2024
enescakir
reviewed
May 21, 2024
enescakir
reviewed
May 21, 2024
velioglu
force-pushed
the
velioglu/gr_e2e_test
branch
10 times, most recently
from
May 23, 2024 07:31
d45cc1e
to
efe96ce
Compare
enescakir
approved these changes
May 23, 2024
We were expecting to pass image version to DownloadBootImage prog. Default version of images were kept in host_nexus. With this commit default version info has been moved to DownloadBootImage. If a version is not passed to DownloadBootImage it will download the default version, if it is passed given version will be downloaded.
Since default version handling is moved from HostNexus to DownloadBootImage doing the same for tests as well.
…tatic domain In order to run github runner e2e tests, local server run on the e2e test machine must be accessible from the public with a static domain. So, the github test app we will create can access e2e test machine even if different hosts can be used. Ngrok is a tool which exposes local server to public. It also supports static domains. So, it can be used to access local server with a same domain. That static domain obtained from ngrok will be used as the base uri for the github test app will be created. It will allow test app to send hooks to the local server running on the e2e test machine.
Keeping workflow information which will be triggered from e2e test machine while running github runner e2e test. It allows us to add new test workflows to trigger, so new workflows can be added easily.
Adding e2e tests for github runners. It basically adds a new strand to the e2e ci. That strand first downloads github runner images to test machine, triggers the test worklfows passed in the github runner test config file and then wait for them to be completed successfully. Since we are running ngrok on the test host and set the ngrok's static domain as the base uri for the test app we create, hooks of triggered workflows will be sent to test host. If you want to add a new repo for github runner tests, make sure that the test app is installed for that repo.
Adding tests for github runner e2e test.
New secrets are added to e2e.yml to - Fetch github runner images from minio - Pass github app information created for e2e tests - Pass github installation id added to the test repo
velioglu
force-pushed
the
velioglu/gr_e2e_test
branch
from
May 23, 2024 17:01
efe96ce
to
493d917
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding github E2E tests. Following items are completed in the PR