Fix display state of PostgreSQL resources #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byucesoy
force-pushed
the
fix-display-state
branch
2 times, most recently
from
c7ca0ba
to
affff7b
Compare
bsatzger
reviewed
May 6, 2024
bsatzger
approved these changes
May 6, 2024
byucesoy
force-pushed
the
fix-display-state
branch
2 times, most recently
from
4edc645
to
dae99d6
Compare
We used to just check the label of PostgresResource's own strand. However, the state of representative server is also important, especially at the time of it being unavailable. This commit fixes the display state of PostgreSQL resources by checking the state of the representative server as well. While doing so, I found another case of wrong display state, while refreshing the dns records, which is also fixed in this commit.
byucesoy
force-pushed
the
fix-display-state
branch
from
dae99d6
to
2956df2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to just check the label of PostgresResource's own strand. However, the state of representative server is also important, especially at the time of it being unavailable. This commit fixes the display state of PostgreSQL resources by checking the state of the representative server as well.
While doing so, I found another case of wrong display state, while refreshing the dns records, which is also fixed in this commit.