Ensure that the runner can log duration even without a vm #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byucesoy
approved these changes
May 3, 2024
byucesoy
reviewed
May 3, 2024
bsatzger
reviewed
May 6, 2024
bsatzger
approved these changes
May 6, 2024
We expect having a VM where we log duration in the runner, but this doesn't seem to always be the case. I've noticed several crashes in the web logs. If a webhook is delivered while the runner is being destroyed, the runner's VM may have already been deleted.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect having a VM where we log duration in the runner, but this doesn't seem to always be the case. I've noticed several crashes in the web logs.
If a webhook is delivered while the runner is being destroyed, the runner's VM may have already been deleted.