Remove unnecessary detach logic from Nic #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detach nic from the VM logic is not needed since we do not support managing nics, yet. There is no need to keep it. I have also moved the cleanup of tunnels to the association_dependencies. Furthermore, since we do not bud any child processes anymore, we do not need to destroy child progs separately at the time of nic destroy.
furkansahin
force-pushed
the
nic_remove_unnec
branch
from
f9276ee
to
28a333b
Compare
byucesoy
approved these changes
May 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detach nic from the VM logic is not needed since we do not support
managing nics, yet. There is no need to keep it.
I have also moved the cleanup of tunnels to the
association_dependencies.
Furthermore, since we do not bud any child processes anymore, we do not
need to destroy child progs separately at the time of nic destroy.