Refactor image download in rhizome side & add optional image version. #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pykello
force-pushed
the
pykello/image_versioning_rhizome
branch
from
2539829
to
07df48c
Compare
|
I was planning to implement fixed versioning for the runner image. This PR will be very helpful. Thank you. |
enescakir
reviewed
Apr 30, 2024
enescakir
reviewed
Apr 30, 2024
enescakir
reviewed
Apr 30, 2024
enescakir
reviewed
Apr 30, 2024
pykello
force-pushed
the
pykello/image_versioning_rhizome
branch
from
07df48c
to
8d80e38
Compare
pykello
force-pushed
the
pykello/image_versioning_rhizome
branch
3 times, most recently
from
962df73
to
306554f
Compare
pykello
force-pushed
the
pykello/image_versioning_rhizome
branch
from
306554f
to
313676e
Compare
pykello
added a commit
that referenced
this pull request
May 2, 2024
In #1524 we changed rhizome to be able to download versioned boot images. In this change, we actually use that infrastructure. To download a versioned boot image, one can do: ``` > vmh.download_boot_image("ubuntu-jammy", version: "20240319") ``` After this has been done, all VMs on that host which want to use the `ubuntu-jammy` image will use the latest boot image. This allows us to be able to download new image versions without impacting previous VMs at all. Previous VMs will continue to use the older images. As follow up items: * VmHost setup will include downloading some default images (e.g. `ubuntu-jammy`) with explicit. vm_setup won't download the images automatically. * We will enforce to use versioned images always * Add a program to remove unused images
byucesoy
reviewed
May 3, 2024
pykello
force-pushed
the
pykello/image_versioning_rhizome
branch
from
313676e
to
6397fc1
Compare
pykello
force-pushed
the
pykello/image_versioning_rhizome
branch
from
6397fc1
to
d54aa7a
Compare
This is in preparation to make boot images versioned. Some of the reasons to do this includes: * Allow installing a newer version of an image without breaking existing VMs which have references to the older versions. * Make storage snapshots easier: we know exactly which base image is being used, and we can just snapshot the diff. * Making correlation of failures to bad OS images easier. Current patch: * Moves almost all of the image download logic to the standalone class BootImage. * Adds optional version and sha256sum parameters to images. If these are null or empty, the behaviour is exactly same as before. * Uses BootImage in VmSetup and `download-boot-image`. If an image is versioned, it'll be stored as `/var/storage/images/$name-$version.raw`. Legacy unversioned images are still supported and are stored at `/var/storage/$name.raw`.
pykello
force-pushed
the
pykello/image_versioning_rhizome
branch
from
d54aa7a
to
cd545b0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation to make boot images versioned. Some of the reasons to do this includes:
Current patch:
download-boot-image.If an image is versioned, it'll be stored as
/var/storage/images/$name-$version.raw. Legacy unversioned images are still supported and are stored at/var/storage/images/$name.raw.