Added carrier support. typpo/textbelt#56 #57
Merged
+424
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Alex, this is a great change! I'm traveling until tomorrow but will test it ASAP, merge, and get it live. 👍 |
|
This looks good overall! I may change it so that you can specify carrier via query param ( I am also concerned about confusing "carriers" with "providers" as they are basically the same thing. We may want to pick one terminology to help disambiguate. Also, we need to update the README and website. This is a sorely needed change so I will merge it and get to work on the rest :) Thank you for the great work! |
|
No probs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a carriers.js file which holds the association of carriers to email addresses. This file was created from the providers.js file.
You can POST to /text getcarriers=1 or getcarriers=true to get the list of supported carriers.
You can POST carrier= to perform the lookup and only email the corresponding email address(es) instead of all of them. If carrier is null the previous behavior of emailing everyone takes effect so as to not break compatibility.
There is also some error handling for when a user specifies a non existent carrier.
Feedback welcome.
#56