Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to have or use API tokens for authentication to use API for self hosted use and as opposed to IP based rate limiting #42

Open
daluu opened this issue Jul 19, 2015 · 1 comment

Comments

@daluu
Copy link
Collaborator

daluu commented Jul 19, 2015

Since the API/server is made public, I was just thinking it would be nice to be like those APIs that have authentication in order to use them, via API tokens (e.g developer/API keys from UI based signup for developer or API usage program, or auto-generated token on each call to some login API that's related to this service's API).

This would be more for self hosted use, but could be considered with the public hosted service in the future.

With this kind of support/implementation, IP based limiting may not be necessary since the token authenticates a legitimate use of the API and we are assuming/expected such, unless the token was hijacked/spoofed of course.

In any case, this is just a suggestion, and other 3rd parties can implement and put in the pull request instead of this specifically targeting the original project. Or someone can mention how to build that in (with integration with another service) if it doesn't really require code changes to the server itself.

@daluu daluu mentioned this issue Jul 19, 2015
@typpo
Copy link
Owner

typpo commented Jul 22, 2015

Right now we have manually generated API tokens for removing rate limiting, in server/keys.json (see server/keys_example.json). I generally just add them when people email me for a rate increase. Agreed that autogenerating these keys or some formal signup/review process would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants